Fix cloud networks access in API #13865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtayadeway
changed the title
abellotti
reviewed
Feb 13, 2017
| :cloud_networks_subcollection_actions: | ||
| :get: | ||
| - :name: show | ||
| - :identifier: miq_cloud_networks_view |
There was a problem hiding this comment.
same thinking, why moving them out of here ? this gives us finer granularity on sub*/roles for the clusters collection
There was a problem hiding this comment.
👍 with these as per our discussion on load balancers PR.
|
This pull request is not mergeable. Please rebase and repush. |
imtayadeway
force-pushed
the
api-cloud-networks-access
branch
from
68a4e20 to
d39a9e1
Compare
|
Checked commits imtayadeway/manageiq@0c15b63~...d39a9e1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 🎵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the cloud networks subcollection actions were not configured correctly, so I added some failing tests and corrected/refactored
@miq-bot add-label api, bug
@miq-bot assign @abellotti