-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Ansible Tower InventoryRootGroup to be of AutomationManager #13852
Conversation
@bdunne this one should be quick. |
@miq-bot add_labels enhancement, providers/ansible_tower |
@jameswnl I don't see a corresponding model for the source or destination type. |
|
||
def up | ||
say_with_time('Migrating STI type of ansible_tower inventory_root_groups to be of automation_manager') do | ||
EmsFolder.where(:type => 'ManageIQ::Providers::AnsibleTower::ConfigurationManager::InventoryRootGroup').update_all( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunne this ^ ManageIQ::Providers::AnsibleTower::ConfigurationManager::InventoryRootGroup
to ManageIQ::Providers::AnsibleTower::AutomationManager::InventoryRootGroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameswnl but there's no model ^
irb(main):008:0> EmsFolder.descendants.collect(&:name).sort
=> ["Datacenter", "ManageIQ::Providers::AutomationManager::InventoryGroup", "ManageIQ::Providers::AutomationManager::InventoryRootGroup", "StorageCluster"]
a4abd3c
to
d5707d2
Compare
@bdunne Good catch. It's under higher level of |
d5707d2
to
079c028
Compare
@jameswnl Can you add the missing leaf model |
Checked commits jameswnl/manageiq@079c028~...c9a1871 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 db/migrate/20170209192130_migrate_ansible_tower_configuration_manager_inventory_root_group_sti_type.rb
spec/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-ansible_tower-automation_manager-inventory_spec.rb
|
@bdunne see the new updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. Leaving the merge for @Fryguy since he's the master of migrations.
@Fryguy can we get this in within the sprint? |
A sequel to #13720
From
ConfigurationManager
toAutomationManager