Fix broken C&U collection #13843
Merged
Fix broken C&U collection #13843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in cases when we don't collect disk size. Addressing failure like: TypeError: nil can't be coerced into Fixnum from app/models/vim_performance_state.rb:156:in `+' from app/models/vim_performance_state.rb:156:in `block in capture_disk_types' from app/models/vim_performance_state.rb:153:in `each_with_object' from app/models/vim_performance_state.rb:153:in `capture_disk_types' from app/models/vim_performance_state.rb:71:in `capture' from app/models/vim_performance_state.rb:53:in `capture' from app/models/metric/ci_mixin/capture.rb:216:in `perf_capture_state'
|
Checked commit isimluk@5c9e231 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in cases when we don't collect disk size.
Addressing failure like:
This is broken since day 0, as I didn't anticipated
nilinDisk.pluck(:size)This code is in master only. So euwe/no.
@miq-bot add_label metrics, bug, euwe/no
@miq-bot assign @gtanzillo