Add SCM options and SCMCredential to Ansible Tower Automation Manager ConfigurationScriptSource #13776
Conversation
|
@miq-bot add_labels wip, enhancement, providers/ansible_provider |
|
@jameswnl Cannot apply the following label because they are not recognized: providers/ansible_provider |
jameswnl
force-pushed
the
tower-project
branch
from
1049233 to
8f34bd8
Compare
|
@miq-bot add_label providers/ansible_tower |
jameswnl
force-pushed
the
tower-project
branch
2 times, most recently
from
529b9d2 to
12ae1f0
Compare
jameswnl
changed the title
|
@miq-bot remove_label wip |
| @@ -1,4 +1,5 @@ | |||
| class ConfigurationScriptSource < ApplicationRecord | |||
| has_many :configuration_script_payloads | |||
| belongs_to :authentications | |||
There was a problem hiding this comment.
Typically a belongs_to is singular. Does this actually work?
There was a problem hiding this comment.
let me write a test to find out :)
There was a problem hiding this comment.
fixed. I've also deleted the spec file which is testing relationships only.
jameswnl
force-pushed
the
tower-project
branch
from
12ae1f0 to
3541b75
Compare
|
Checked commit jameswnl@3541b75 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-ansible_tower-automation_manager-scm_credential_spec.rb
|
| expect(payloads[0].configuration_script_source).to eq(configuration_script_source) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
these are just testing rails
There was a problem hiding this comment.
Ah ok...I remember that discussion, but I thought it was from a different PR. This is fine.
We need to keep these information so that when UI provide edit, there'll be existing values to be displayed.