Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miq widget columns #13753

Merged
merged 4 commits into from
Feb 7, 2017
Merged

Miq widget columns #13753

merged 4 commits into from
Feb 7, 2017

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 2, 2017

low hanging virtual_delegation changes for MiqWidget

@kbrock kbrock added the core label Feb 2, 2017
@kbrock kbrock force-pushed the miq_widget_columns branch from 8b4de59 to 7aaf73c Compare February 6, 2017 18:03
@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2017

Checked commits kbrock/manageiq@6b49ba3~...7aaf73c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

spec/models/miq_widget_spec.rb

isimluk
isimluk reviewed Feb 7, 2017
View reviewed changes
spec/models/miq_widget_spec.rb
end

it "uses task value" do
dt = Time.now.utc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop this.

isimluk
isimluk approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 🍰 🍷

gtanzillo
gtanzillo approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! 👍

@gtanzillo gtanzillo added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 7, 2017
@gtanzillo gtanzillo merged commit cdae89a into ManageIQ:master Feb 7, 2017
@kbrock kbrock deleted the miq_widget_columns branch February 7, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isimluk isimluk isimluk approved these changes

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbrock @miq-bot @gtanzillo @isimluk