Chargeback: Skip calculation when there is zero consumed hours #13723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumed_hours_in_interval are used for calculating average consumption.
When you divide by zero you get Infinity as a result. The report
formatter breaks when it find Infinity record.
WARN -- : <AuditFailure> MIQ(Async.rescue in _async_generate_table) userid: [admin] - Infinity
ERROR -- : MIQ(MiqQueue#deliver) Message id: [6427], Error: [Infinity]
ERROR -- : [FloatDomainError]: Infinity Method:[rescue in deliver]
ERROR -- : activesupport-5.0.0.1/lib/active_support/number_helper/number_to_human_size_converter.rb:53:in `to_i'
This is corner case. It can happen only few hours after you add provider
with C&U. Then it is possible some metric rollup exists in the interval,
while the full consumed hours is zero.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1416626
|
Checked commit isimluk@526b0df with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Feb 3, 2017
Chargeback: Skip calculation when there is zero consumed hours (cherry picked from commit bf42c47) https://bugzilla.redhat.com/show_bug.cgi?id=1419186
|
Euwe backport details: |
isimluk
added a commit
to isimluk/manageiq
that referenced
this pull request
Feb 6, 2017
After we backported ManageIQ#13723 we found that one test fails as it process metric rollups that are older than the vm (that wouldn't happen outside of tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumed_hours_in_interval are used for calculating average metrics. When you divide by zero you get Infinity as a result. The report formater breaks when it gets Infinity.
This is a corner case. It can happen only few hours after you add provider with C&U. Then it is possible some metric rollup exists in the interval, while the full consumed hours is zero.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1416626
@miq-bot add_label chargeback, bug, euwe/yes, blocker
@miq-bot assign @gtanzillo