Add View and Modify/Add RBAC features for the Embedded Automation Provider #13716
Conversation
|
@miq-bot add_label wip, enhancement |
|
@dclarizio , @Fryguy - please review |
lgalis
changed the title
|
@miq-bot remove_label wip |
db/fixtures/miq_product_features.yml
Outdated
|
|
||
| # Embedded Automation Manager | ||
| - :name: Embedded Automation Manager | ||
| :description: Everything under Embedded Automation Manager |
There was a problem hiding this comment.
The descriptions of the features need to match the UI tabs
lgalis
changed the title
|
@miq-bot add_label wip |
lgalis
force-pushed
the
add_embedded_automation_manager_view_modify_features
branch
from
2e40193 to
427bba1
Compare
db/fixtures/miq_product_features.yml
Outdated
| - :name: Repositories | ||
| :description: Everything under Repositorie | ||
| :feature_type: node | ||
| :identifier: configuration_script_source |
There was a problem hiding this comment.
@lgalis I thought we had discussed that the "external" ones would be the ones without the prefix, and that "embedded" (because it's the abnormal one) would have the prefix of "embedded"? This seems to be the opposite.
There was a problem hiding this comment.
@Fryguy - The playbooks and repos are only for the embedded ansible - but I agree, that may change - so I added the 'embedded' prefix
|
|
||
| # Embedded Automation Manager | ||
| - :name: Embedded Automation Manager | ||
| :description: Everything under Ansible |
There was a problem hiding this comment.
This should not say Ansible at this level, I think.
There was a problem hiding this comment.
@Fryguy @dclarizio - the menu says Ansible for the internal one. What should it be here?
There was a problem hiding this comment.
@Fryguy this has to match the menus and the menu here says "Ansible". If we want to change it here to something else, we need to clear that with PM, as the menu title will need to change. So according to the current mockups, this should be name: Ansible I think.
db/fixtures/miq_product_features.yml
Outdated
| :identifier: embedded_automation_manager | ||
| :children: | ||
| - :name: Repositories | ||
| :description: Everything under Repositorie |
db/fixtures/miq_product_features.yml
Outdated
| :identifier: configuration_script_source | ||
| :children: | ||
| - :name: View | ||
| :description: View Respositories |
There was a problem hiding this comment.
Typo Respositories -> Repositories
lgalis
force-pushed
the
add_embedded_automation_manager_view_modify_features
branch
from
427bba1 to
784404f
Compare
lgalis
force-pushed
the
add_embedded_automation_manager_view_modify_features
branch
from
7e7f22f to
29673f6
Compare
|
Checked commits lgalis/manageiq@aa87844~...29673f6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lgalis
changed the title
|
@Fryguy - please review |
Add View and Modify/Add RBAC features for the Embedded Automation Provider
Links
https://www.pivotaltracker.com/story/show/138739009