Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MiqUserRole to RBAC #13689

Merged
merged 4 commits into from
Feb 1, 2017
Merged

Add MiqUserRole to RBAC #13689

merged 4 commits into from
Feb 1, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jan 30, 2017 •
edited by miq-bot
Loading

fixes ManageIQ/manageiq-ui-classic#135

For now just fix the mentioned issue.

Hide super_administator role for Users and Groups with tenant_admininistrator role

@miq-bot add_label rbac, bug

cc @martinpovolny

@miq-bot assign @gtanzillo

@lpichler lpichler mentioned this pull request Jan 30, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Jan 30, 2017

Checked commits lpichler/manageiq@0428548~...81c67f5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 1 offense detected

app/models/miq_group.rb

gtanzillo
gtanzillo approved these changes Jan 31, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. @martinpovolny, please review and let me know if you're ok with merging. Thanks.

@martinpovolny
Copy link
Member

@gtanzillo : looks good to me.
@lpichler : thx!

@martinpovolny martinpovolny merged commit f9d354d into ManageIQ:master Feb 1, 2017
@martinpovolny martinpovolny self-assigned this Feb 1, 2017
@lpichler lpichler deleted the add_miq_user_role_to_rbac branch February 1, 2017 10:01
@martinpovolny martinpovolny added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 1, 2017
@kbrock
Copy link
Member

kbrock commented Feb 1, 2017

nice fix libor

@isimluk
Copy link
Member

isimluk commented Feb 2, 2017

raise condition, I think bz for this already filed in https://bugzilla.redhat.com/show_bug.cgi?id=1418662

@lpichler
Copy link
Contributor Author

lpichler commented Feb 2, 2017

thanks @isimluk for BZ, @simaishi - so bugzilla is needed only for EUWE

@martinpovolny
Copy link
Member

yes, there's a 5.6 but linked above
there's also a 5.7: https://bugzilla.redhat.com/show_bug.cgi?id=1418297

@martinpovolny
Copy link
Member

ping @simaishi

simaishi pushed a commit that referenced this pull request Feb 6, 2017
@martinpovolny @simaishi
Merge pull request #13689 from lpichler/add_miq_user_role_to_rbac
3c42361 
Add MiqUserRole to RBAC
(cherry picked from commit f9d354d)

https://bugzilla.redhat.com/show_bug.cgi?id=1419686
@simaishi
Copy link
Contributor

simaishi commented Feb 6, 2017

Euwe backport details:

$ git log -1
commit 3c42361aa393418aef5189fe39176cca09e7be55
Author: Martin Povolny <[email protected]>
Date:   Wed Feb 1 11:01:28 2017 +0100

    Merge pull request #13689 from lpichler/add_miq_user_role_to_rbac
    
    Add MiqUserRole to RBAC
    (cherry picked from commit f9d354db60d84f2ab3bd67a79565bb3c0a62ed19)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1419686

@lpichler lpichler mentioned this pull request Feb 27, 2017
Merged
@lpichler lpichler mentioned this pull request Apr 3, 2017
Merged
@lpichler lpichler mentioned this pull request Apr 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
blocker bug core/rbac euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A tenant admin can create a user with role EvmRole-super_administrator
7 participants
@lpichler @miq-bot @martinpovolny @kbrock @isimluk @simaishi @gtanzillo