add create_catalog_item to ServiceTemplateOrchestration

[jntullo]

This adds class method create_catalog_item to ServiceTemplateOrchestration and takes in the following:

{
        :name         => 'Orchestration Template',
        :service_type => 'atomic',
        :prov_type    => 'generic_orchestration',
        :display      => 'false',
        :description  => 'a description',
        :config_info  => {
          :template_id => template.id,
          :manager_id  => manager.id,
          :provision   => {
            :fqname            => ra1.fqname,
            :dialog_id => service_dialog.id
          },
          :retirement  => {
            :fqname            => ra2.fqname,
            :dialog_id => service_dialog.id
          }
        }
      }

@miq-bot enhancement, euwe/no, services, wip
@miq-bot assign @bzwei

[bzwei]

Do we want to validate both template and manager must exist? If this is the only call we should unless users can call update method to set them later. This make me think of the need for update method and delete method as a complete solution.

[jntullo]

@bzwei yeah, good point. if both are required for a valid orchestration template, we should check that both exist, as well as make an update / delete method.

[bzwei]

You allow a case that neither exists. Let's make it simpler by requiring both must exist.

[jntullo]

@bzwei oh gotcha. was thinking it was either one or the other

[bzwei]

So here there is no need for the if statement

[bzwei]

@jntullo Let's change :service_dialog_id to :dialog_id. This is inline with the column name for ResourceAction You need to change in the base method too. Thanks.

[bzwei]

We want to accept :template_id or :template. The later points to an object that can be directly assigned. Same to manager. Need to update the validate method too.

[jntullo]

@bzwei should I check for combinations of ids / objects?

[bzwei]

Ideally we should allow the combination. What you have here is likely real. I am ok with it.

[miq-bot]

Checked commits jntullo/manageiq@ce9b22b~...911d7fd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 👍

[jntullo]

@miq-bot remove_label wip

[bzwei]

We may simply put config_info[:template] || OrchestrationTemplate.find(config_info[:template_id]) since we already validate either one must exist.

[jntullo]

@bzwei I wanted to, but the line was too long so rubocop wasn't happy, and this was more readable than breaking that up onto two lines imo

[bzwei]

@miq-bot assign @gmcculloug

[gmcculloug]

@jntullo I would suggest allowing for the different combinations since that would better align with the logic in the create_catalog_item method. This can be done in a followup PR.