-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Amazon block storage refresh worker class #13457
Add Amazon block storage refresh worker class #13457
Conversation
You mean this PR requires ManageIQ/manageiq-providers-amazon#101, don't you? |
@roliveri honestly, I thought it is "required" by the other PR. If these classes are not registered, the refresh worker is of course not started. However, I didn't think about the other way around. Unfortunately, I don't know how best to approach such commits that span across multiple repositories. |
@roliveri dependent PR(ManageIQ/manageiq-providers-amazon#101) has just been merged by @Ladas. |
@gberginc close&open the PR, it will restart the CI, it should pass now |
2b0051b
to
d7bd543
Compare
@miq-bot add_label euwe/no |
d7bd543
to
f66bfc5
Compare
Specification of this class is required for MiQ to be aware of the new refresh worker supporting Amazon EBS block storage refresh parser. Signed-off-by: Gregor Berginc <[email protected]>
f66bfc5
to
6c68f16
Compare
Checked commit xlab-si@6c68f16 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 |
Closing in favour of #13569 |
Specification of this class is required for MiQ to be aware of the new
refresh worker supporting Amazon block storage refresh parser.
This PR is required by ManageIQ/manageiq-providers-amazon#101.
@miq-bot add_label providers/amazon