Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon block storage refresh worker class #13457

Conversation

gberginc
Copy link
Contributor

Specification of this class is required for MiQ to be aware of the new
refresh worker supporting Amazon block storage refresh parser.

This PR is required by ManageIQ/manageiq-providers-amazon#101.

@miq-bot add_label providers/amazon

@roliveri
Copy link
Member

@gberginc

This PR is required by ManageIQ/manageiq-providers-amazon#101.

You mean this PR requires ManageIQ/manageiq-providers-amazon#101, don't you?

@gberginc
Copy link
Contributor Author

@roliveri honestly, I thought it is "required" by the other PR. If these classes are not registered, the refresh worker is of course not started. However, I didn't think about the other way around.

Unfortunately, I don't know how best to approach such commits that span across multiple repositories.

@gberginc
Copy link
Contributor Author

@roliveri dependent PR(ManageIQ/manageiq-providers-amazon#101) has just been merged by @Ladas.

@Ladas
Copy link
Contributor

Ladas commented Jan 17, 2017

@gberginc close&open the PR, it will restart the CI, it should pass now

@gberginc gberginc closed this Jan 17, 2017
@gberginc gberginc reopened this Jan 17, 2017
@gberginc gberginc force-pushed the add_amazon_block_storage_refresh_worker branch from 2b0051b to d7bd543 Compare January 17, 2017 16:44
@gberginc
Copy link
Contributor Author

@miq-bot add_label euwe/no

Specification of this class is required for MiQ to be aware of the new
refresh worker supporting Amazon EBS block storage refresh parser.

Signed-off-by: Gregor Berginc <[email protected]>
@gberginc gberginc force-pushed the add_amazon_block_storage_refresh_worker branch from f66bfc5 to 6c68f16 Compare January 17, 2017 21:39
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2017

Checked commit xlab-si@6c68f16 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@gberginc
Copy link
Contributor Author

Closing in favour of #13569

@gberginc gberginc closed this Jan 18, 2017
@tadeboro tadeboro deleted the add_amazon_block_storage_refresh_worker branch March 30, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants