Charge SCVMM's vm only until it is retired. #13451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
force-pushed
the
chargebacks-without-rollups-till-retirement
branch
from
384f17d to
b449896
Compare
isimluk
force-pushed
the
chargebacks-without-rollups-till-retirement
branch
from
b449896 to
41e9832
Compare
When resource did not exist in given interval (day, week, month) we will not yield Consumption object into the chargeback engine. As a result the report won't contain rows with zero consumption.
|
Checked commits isimluk/manageiq@41e9832~...166896f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/chargeback/consumption.rb
|
Nice catch @lpichler!
|
Backported to Euwe via #13554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't collect metric for SCVMM, we need to explicitly stop charging once the resource is retired.
Unfortunately, we don't store archived_on date atm. So, we need to rely on retirement.
@miq-bot add_label enhancement, chargeback
@miq-bot assign @gtanzillo