Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EUWE] Launch an URL returned by an automate button #13449

Merged
merged 10 commits into from
Jan 12, 2017
Merged

[EUWE] Launch an URL returned by an automate button #13449

merged 10 commits into from
Jan 12, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Jan 11, 2017 •
edited
Loading

@martinpovolny
Copy link
Member Author

@h-kataria : review, please?

@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2017

Some comments on commits martinpovolny/manageiq@dc1a4b5~...e9fd798

spec/controllers/application_controller/buttons_spec.rb

  • ⚠️ - 55 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2017

Checked commits martinpovolny/manageiq@dc1a4b5~...e9fd798 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
8 files checked, 0 offenses detected
Everything looks good. 🍪

@Fryguy Fryguy changed the title [Euwe] Launch an URL returned by an automate button [EUWE] Launch an URL returned by an automate button Jan 11, 2017
@simaishi simaishi requested a review from gmcculloug January 11, 2017 18:41
gmcculloug
gmcculloug approved these changes Jan 11, 2017
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Looks like there is an unrelated test failure right now.

@simaishi simaishi merged commit 83d507e into ManageIQ:euwe Jan 12, 2017
@simaishi simaishi removed the euwe/yes label Jan 12, 2017
@simaishi simaishi mentioned this pull request Jan 12, 2017
Merged
@simaishi simaishi modified the milestone: Sprint 52 Ending Jan 16, 2017 Jan 13, 2017
@martinpovolny martinpovolny deleted the bz_1399679 branch November 28, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@simaishi simaishi

Labels
enhancement ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @gmcculloug @simaishi @h-kataria