[EUWE] Cloud Network UI: Task queue, validation, buttons and translation #13416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
tzumainn
force-pushed
the
euwe-backport-network-task
branch
from
7638fcf to
3eb6023
Compare
gildub
reviewed
Jan 11, 2017
| javascript_redirect previous_breadcrumb_url | ||
| def update_finished | ||
| task_id = session[:async][:params][:task_id] | ||
| cloud_network_id = session[:async][:params][:id] |
|
@miq-bot add_label euwe/yes |
tzumainn
force-pushed
the
euwe-backport-network-task
branch
from
3eb6023 to
05e1d05
Compare
https://bugzilla.redhat.com/show_bug.cgi?id=1394281 This is an Euwe-only PR to resolve conflicts with: app/controllers/cloud_network_controller.rb app/models/manageiq/providers/openstack/network_manager.rb This PR is equivalent to ManageIQ#12071 on master.
tzumainn
force-pushed
the
euwe-backport-network-task
branch
from
05e1d05 to
0b86cdd
Compare
|
Checked commit tzumainn@0b86cdd with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/controllers/cloud_network_controller.rb
app/helpers/application_helper/toolbar/cloud_networks_center.rb
spec/controllers/cloud_network_controller_spec.rb
|
|
@martinpovolny @gildub is this good to go? |
|
@simaishi, This is good to go! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1394281
This is an Euwe-only PR to resolve conflicts with:
This PR is equivalent to #12071
on master.