Inventory and inventory target abstraction for refreshes with new strategies #13407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A proper init for the db_cached_all InventoryCollection, the inventory collection must behave the same regardless the source of the data coming from the DB or the API.
RefreshParserInventoryObject base class with Inventory
Add strategy local_db_find_one allowing to find one in the DB. This strategy is effective for targetted refresh, where we load small number of relations.
Allow to disable changed? check before updating record, we need to disable it e.g. for AWS Vms, since we can change what images we collect. Changing of vm's image, is not caught by changed?
Add also strategy name to inventory_collection inspect
Find should handle nil gracefully
This strategy is comes handy when we do targeted refresh of a inventory_collection while there is a lazy_link to record present only in the DB. E.g. we refresh a VM and Hardware, but hardware has a lazy link to hardware owned by Vm's image.
Fix save_inventory helper log messages
|
Checked commits Ladas/manageiq@cb7ba93~...b2ad914 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/manager_refresh/inventory_collection.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inventory and inventory target abstraction for refreshes with new strategies needed for the inventory refresh.