Rename events "ExtManagementSystem Compliance *" -> "Provider Compliance *"

[cben]

Followup to #11002,
https://bugzilla.redhat.com/show_bug.cgi?id=1411337 (master)
https://bugzilla.redhat.com/show_bug.cgi?id=1411364 (euwe)

Before:

After (this PRs only fixes the event name, icons fixed in UI PR ManageIQ/manageiq-ui-classic/pull/94):

Low-level names remain extmanagementsystem_compliance_*, should be backward compatible given existing policies with these events.

I thought this csv is loaded on every run, but it seems I needed rake db:seed to take effect.

[miq-bot]

Checked commit cben@36ca6ea with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🍪

[simon3z]

@cben do you think this can be done? These are fixtures, what about existing installations out there?

[cben]

AFAIK everything else in DB references the internal_event_names (which I didn't change), and the Human Description is only used in UI. I've confirmed that given an existing policy, after this PR (and possibly db:seed?) makes the policy display the new event name in UI. So I *believe* it's safe and backward compatible. But I might be missing something. 2017-02-01 0:28 GMT+02:00 Federico Simoncelli <[email protected]>:

…

@cben <https://github.com/cben> do you think this can be done? These are fixtures, what about existing installations out there? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13388 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQtGFg0Pid4HV75eNYnmFb3PMzPLzh0ks5rX7WagaJpZM4LdrMd> .

[simon3z]

LGTM 👍

@gtanzillo do you have any insight on the backward compatibility? (It seems OK but you know more for sure)

Since this is impacting UI @h-kataria @dclarizio do you want to review/ack/nack?

Assigning to @gtanzillo for backward compatibility comments and review/merge.

@miq-bot assign gtanzillo

[dclarizio]

Since this is impacting UI @h-kataria @dclarizio do you want to review/ack/nack?

Makes sense to me!

[gmcculloug]

Looks good. Might want to see if there is documentation that need to be updated with this change.

[cben]

Ping @gmcculloug so can this be merged?

This renaming itself doesn't require doc changes, but these events are missing from the list
http://manageiq.org/docs/reference/latest/doc-Policies_and_Profiles_Guide/miq/#chap_events,
I'll send a docs PR soon => ManageIQ/manageiq-documentation#223

[cben]

These events appeared in euwe, would be nice to call the consitently there too, if there are not concerns.

@miq-bot add-label euwe/yes

[gmcculloug]

Yes, I am good with merging. @gtanzillo Any concerns, if not please merge.

[gtanzillo]

👍 LGTM

[simaishi]

Euwe backport details:

$ git log -1
commit ab2c70319ea2ed076081eb948597deaccb9060a6
Author: Gregg Tanzillo <[email protected]>
Date:   Wed Feb 8 09:17:14 2017 -0500

    Merge pull request #13388 from cben/provider-compliance-events-description
    
    Rename events "ExtManagementSystem Compliance *" -> "Provider Compliance *"
    (cherry picked from commit af4f115902f3dfc2feec7f3c71678123c94014c6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1411364