Rename dto to inventory

[Ladas]

Rename 'dto' to 'inventory', which is more understandable term

[Ladas]

@miq-bot assign @agrare

[Ladas]

@agrare just the rename we talked about

[miq-bot]

Checked commit Ladas@416f07f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
17 files checked, 83 offenses detected

app/models/manager_refresh/graph/topological_sort.rb

• ❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [126/120]

app/models/manager_refresh/inventory_collection.rb

• ❗ - Line 167, Col 27 - Style/SpaceAroundOperators - Operator += should be surrounded by a single space.
• ❗ - Line 242, Col 11 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 245, Col 11 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 71, Col 11 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 73, Col 11 - Style/RedundantSelf - Redundant self detected.
• ❕ - Line 12, Col 19 - Metrics/ParameterLists - Avoid parameter lists longer than 5 parameters.
• ❕ - Line 12, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for initialize is too high. [25.02/20]
• ❕ - Line 12, Col 5 - Metrics/CyclomaticComplexity - Cyclomatic complexity for initialize is too high. [13/6]
• ❕ - Line 12, Col 5 - Metrics/PerceivedComplexity - Perceived complexity for initialize is too high. [13/7]
• ❕ - Line 163, Col 121 - Metrics/LineLength - Line is too long. [121/120]
• ❕ - Line 238, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for actualize_dependencies is too high. [25.57/20]
• ❕ - Line 2, Col 3 - Metrics/ClassLength - Class has too many lines. [205/100]

app/models/manager_refresh/inventory_collection/graph.rb

• ❕ - Line 120, Col 121 - Metrics/LineLength - Line is too long. [125/120]
• ❕ - Line 121, Col 121 - Metrics/LineLength - Line is too long. [154/120]
• ❕ - Line 122, Col 121 - Metrics/LineLength - Line is too long. [129/120]
• ❕ - Line 59, Col 121 - Metrics/LineLength - Line is too long. [127/120]
• ❕ - Line 64, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for convert_to_dag! is too high. [26.17/20]

app/models/manager_refresh/inventory_object.rb

• ❕ - Line 26, Col 121 - Metrics/LineLength - Line is too long. [137/120]
• ❕ - Line 60, Col 121 - Metrics/LineLength - Line is too long. [143/120]
• ❕ - Line 61, Col 121 - Metrics/LineLength - Line is too long. [144/120]

app/models/manager_refresh/inventory_object_lazy.rb

• ❗ - Line 31, Col 7 - Style/DoubleNegation - Avoid the use of double negation (!!).
• ❗ - Line 38, Col 7 - Style/DoubleNegation - Avoid the use of double negation (!!).
• ❕ - Line 60, Col 121 - Metrics/LineLength - Line is too long. [121/120]

app/models/manager_refresh/save_collection/helper.rb

• ❗ - Line 69, Col 37 - Style/SpaceAroundOperators - Operator += should be surrounded by a single space.
• ❕ - Line 48, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for create_or_update_inventory! is too high. [30.82/20]
• ❕ - Line 48, Col 5 - Metrics/MethodLength - Method has too many lines. [27/25]
• ❕ - Line 4, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• ❕ - Line 61, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• ❕ - Line 89, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• ❕ - Line 99, Col 121 - Metrics/LineLength - Line is too long. [122/120]

app/models/manager_refresh/save_collection/recursive.rb

• ❕ - Line 19, Col 121 - Metrics/LineLength - Line is too long. [125/120]

app/models/manager_refresh/save_collection/topological_sort.rb

• ❕ - Line 6, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for save_collections is too high. [31.34/20]

app/models/manager_refresh/save_inventory.rb

• ❕ - Line 7, Col 121 - Metrics/LineLength - Line is too long. [127/120]

spec/models/manager_refresh/save_inventory/acyclic_graph_of_inventory_collections_spec.rb

• ❗ - Line 446, Col 71 - Style/WordArray - Use %w or %W for an array of words.
• ❕ - Line 427, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for assert_full_inventory_collections_graph is too high. [114.3/20]
• ❕ - Line 427, Col 3 - Metrics/MethodLength - Method has too many lines. [33/25]
• ❕ - Line 471, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for initialize_data_and_inventory_collections is too high. [181.2/20]
• ❕ - Line 471, Col 3 - Metrics/MethodLength - Method has too many lines. [118/25]
• ❕ - Line 613, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for initialize_mocked_records is too high. [94.25/20]
• ❕ - Line 613, Col 3 - Metrics/MethodLength - Method has too many lines. [119/25]

spec/models/manager_refresh/save_inventory/graph_of_inventory_collections_spec.rb

• ❗ - Line 1063, Col 44 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 1063, Col 47 - Style/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 1070, Col 44 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 1070, Col 47 - Style/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 1077, Col 45 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 1077, Col 47 - Style/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 1081, Col 45 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 1081, Col 47 - Style/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 1085, Col 45 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 1085, Col 47 - Style/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❕ - Line 1008, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for init_stack_data_with_stack_stack_cycle is too high. [42.58/20]
• ❕ - Line 1025, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for init_stack_data_with_stack_resource_stack_cycle is too high. [42.58/20]
• ❕ - Line 1025, Col 3 - Metrics/MethodLength - Method has too many lines. [28/25]
• ❕ - Line 1062, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for init_resource_data is too high. [52.47/20]
• ❕ - Line 1062, Col 3 - Metrics/MethodLength - Method has too many lines. [26/25]
• ❕ - Line 1091, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for initialize_mocked_records is too high. [53.85/20]
• ❕ - Line 1091, Col 3 - Metrics/MethodLength - Method has too many lines. [75/25]
• ❕ - Line 329, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• ❕ - Line 399, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• ❕ - Line 686, Col 121 - Metrics/LineLength - Line is too long. [123/120]
• ❕ - Line 843, Col 121 - Metrics/LineLength - Line is too long. [138/120]
• ❕ - Line 922, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for assert_full_inventory_collections_graph is too high. [98.99/20]
• ❕ - Line 922, Col 3 - Metrics/MethodLength - Method has too many lines. [52/25]

spec/models/manager_refresh/save_inventory/graph_of_inventory_collections_targeted_refresh_spec.rb

• ❗ - Line 284, Col 1 - Style/EmptyLines - Extra blank line detected.
• ❗ - Line 301, Col 19 - Style/WordArray - Use %w or %W for an array of words.
• ❗ - Line 385, Col 19 - Style/WordArray - Use %w or %W for an array of words.
• ❕ - Line 285, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• ❕ - Line 312, Col 121 - Metrics/LineLength - Line is too long. [125/120]
• ❕ - Line 396, Col 121 - Metrics/LineLength - Line is too long. [125/120]
• ❕ - Line 480, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for load_records is too high. [28.28/20]
• ❕ - Line 509, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for assert_relations is too high. [97/20]
• ❕ - Line 537, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for assert_everything_is_collected is too high. [33.24/20]
• ❕ - Line 537, Col 3 - Metrics/MethodLength - Method has too many lines. [112/25]
• ❕ - Line 768, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for initialize_inventory_collection_data is too high. [130.5/20]
• ❕ - Line 768, Col 3 - Metrics/MethodLength - Method has too many lines. [64/25]

spec/models/manager_refresh/save_inventory/single_inventory_collection_spec.rb

• ❗ - Line 164, Col 15 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
• ❗ - Line 248, Col 38 - Style/MultilineMethodCallIndentation - Align .detect with .model_class on line 247.
• ❗ - Line 563, Col 15 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
• ❕ - Line 498, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• ❕ - Line 499, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• ❕ - Line 523, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• ❕ - Line 524, Col 121 - Metrics/LineLength - Line is too long. [124/120]

[agrare]

LGTM