Fix creating Kubernetes or OSE with credentials.auth_key

[cben]

Passing credentials containing auth_key was failing with:

Could not create the new provider - Unsupported credential attributes auth_key specified

Worked with Openshift.

(The recommended way to create Openshift with hawkular metrics is pass connection_configurations, which works.
But passing hostname/ip, port and credentials should work when you don't need a hawkular endpoint (and currently will still attempt metrics if there is hawkular on same hostname with default port 443).)

@miq-bot add-label bug, providers/containers, api

Tests (this part already got merged in #13369)

Extended api/providers_spec.rb to run the container tests for all 3 concrete container manager classes, instead of just Openshift::ContainerManager.
I also tried using shared_example instead of loops, found the results less satisfactory.

This file now takes ~17s instead of ~15s. IMO, despite exercising mostly the same mixing code it's well worth it:

• In addition to the bug I'm fixing now, this testing uncovered bug Can't create Kubernetes provider with port other than 6443 #13306!
  Marked that test pending, will address later.
• Beside 2 Manager Mixins included in 3 concrete manager classes, there are complex interactions with Authentication, Endpoint, AuthenticationMixin, UI + API, single-endpoint interfaces like credentials vs connection_configurations, and fallbacks from hawkular endpoint to default endpoint...
  I find it very hard to reason about, and to even start simplifying it requires test coverage.

P.S. The "schedules a new credentials check if endpoint change" test is known to be a lie, should fail (#13167). Will address in later PR.

@yaacov @dkorn Please review.

[yaacov]

LGTM 👍
[ except that the pending thing is not nice ...
can you fix the port issue and remove the pending ? ]

[cben]

I'm working on several PRs that will all depend on / benefit from the extended tests here.
(To Yaacov's point, one of these PRs will fix the pending #13306.
UPDATE: #13369 fixed this pending test, #13306 still open as root cause affects other places.)
@abellotti Can you take a look?

[simon3z]

(The recommended way to create Openshift with hawkular metrics is pass connection_configurations, which works.
But passing hostname/ip, port and credentials should work when you don't need a hawkular endpoint (and currently will still attempt metrics if there is hawkular on same hostname with default port 443).)

@cben can you provide an example of the request that works and the one that is not working but should work?

[cben]

Didn't work (Unsupported credential attributes auth_key specified), fixed here:

    {
      "type"              : "ManageIQ::Providers::OpenshiftEnterprise::ContainerManager",
      "name"              : "sample containers",
      "port"              : 18443,
      "hostname"          : "sample_containers.provider.com",
      "ipaddress"         : "100.200.300.3",
      "credentials"       : {
        "auth_type" : "bearer",
        "auth_key"  : "good token"
      }
    }

Worked:

    {
      "type"                      : "ManageIQ::Providers::OpenshiftEnterprise::ContainerManager",
      "name"                      : "sample containers provider with multiple endpoints",
      "connection_configurations" : [
        {
          "endpoint"      : {
            "role"     : "default",
            "hostname" : "sample_containers_multi_end_point.provider.com",
            "port"     : 18443
          },
          "authentication": {
            "role"     : "bearer",
            "auth_key" : "good token"
          }
        }
      ]
    }

CORRECTION: Openshift already worked, changed examples to OpenshiftEnterprise.
P.S. @yaacov asked why both hostname & ipaddress. Yes, redundant.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[yaacov]

LGTM 👍

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commit cben@76548ed with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🏆

[cben]

Rebased. @blomquisg @abellotti, this is a tiny fix.

[simon3z]

LGTM 👍
ping @blomquisg @abellotti

@miq-bot assign blomquisg

[abellotti]

I'm good with API changes. Thanks.