Allow a service power state to correctly handle nil actions #13232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmcculloug - Please review cc @AparnaKarve |
|
@miq-bot add_label 'blocker', 'services' |
|
@syncrou Cannot apply the following labels because they are not recognized: 'blocker', 'services' |
syncrou
force-pushed
the
assume_when_all_nil_actions
branch
from
b6d7bba to
ec71612
Compare
|
@miq-bot add_label blocker, services |
syncrou
force-pushed
the
assume_when_all_nil_actions
branch
from
ec71612 to
13244c6
Compare
|
@miq-bot add_label bug |
gmcculloug
reviewed
Jan 23, 2017
| end | ||
|
|
||
| def composite? | ||
| service_template.service_type == 'composite' |
There was a problem hiding this comment.
Does it make sense to delegate the service_type? Then you can remove the service_template reference from atomic? and composite?.
In the case where the :start_action or :stop_action was not set on a service we need to assume the user would want a :start_action to equal 'Power On' and subsequently a nil :stop_action would equal a 'Power Off' This change only affects services where none of the start or stop actions were set This change also correctly handles passing back the power state and power status for atomic services If a user sets any of the service actions then we assume they meant to leave some of them as 'Do Nothing' https://bugzilla.redhat.com/show_bug.cgi?id=1394202
syncrou
force-pushed
the
assume_when_all_nil_actions
branch
from
13244c6 to
6661b89
Compare
|
Checked commit syncrou@6661b89 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 spec/models/service_spec.rb
|
simaishi
pushed a commit
that referenced
this pull request
Jan 23, 2017
Allow a service power state to correctly handle nil actions (cherry picked from commit 656bbc8) https://bugzilla.redhat.com/show_bug.cgi?id=1402995
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where the :start_action or :stop_action was not set on a service
we need to assume the user would want a :start_action to equal 'Power On'
and subsequently a nil :stop_action would equal a 'Power Off'
This change only affects services where none of the start or stop actions were set
This change also correctly handles passing back the
power state and power status for atomic services
If a user sets any of the service actions then we assume they meant to leave some of them as 'Do Nothing'
https://bugzilla.redhat.com/show_bug.cgi?id=1394202
Steps for Testing/QA
start_actionblank (via the classic UI)power_stateof the service after the VMs for that service have started.Repeat to test the
stop_actionbut leave that field blank in the classic UIpower_stateof the service after the VM for the service has started.