Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display IPv6Address on VM summary page #13190

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Display IPv6Address on VM summary page #13190

merged 1 commit into from
Dec 19, 2016

Conversation

jameswnl
Copy link
Contributor

Currently only IPv4 addresses are displayed on VM summary page. This PR is to have IPv6 displayed as well.

Basically, vm.ipaddresses will now include IPv6 addresses as well.

https://bugzilla.redhat.com/show_bug.cgi?id=1375737

@jameswnl
Copy link
Contributor Author

@miq-bot add_labels bug, providers

@jameswnl
Copy link
Contributor Author

@Ladas can you help take a look?

@miq-bot
Copy link
Member

miq-bot commented Dec 15, 2016

Checked commit jameswnl@e46e282 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🏆

@jameswnl
Copy link
Contributor Author

@miq-bot add_label wip

@Ladas
Copy link
Contributor

Ladas commented Dec 15, 2016

👍 looks good

@jameswnl jameswnl changed the title [WIP] display IPv6Address on VM summary page Display IPv6Address on VM summary page Dec 15, 2016
@jameswnl
Copy link
Contributor Author

@miq-bot remove_label wip

@agrare agrare self-assigned this Dec 19, 2016
@agrare
Copy link
Member

agrare commented Dec 19, 2016

LGTM

@agrare agrare merged commit 4529df7 into ManageIQ:master Dec 19, 2016
@agrare agrare added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 19, 2016
@agrare agrare added the euwe/no label Dec 19, 2016
@miq-bot miq-bot added bug wip and removed wip labels Dec 20, 2016
@imtayadeway
Copy link
Contributor

If possible, we'd like to backport this to fix https://bugzilla.redhat.com/show_bug.cgi?id=1375740

@miq-bot rm-label euwe/no
@miq-bot add-label euwe/yes, darga/yes

@miq-bot miq-bot changed the title Display IPv6Address on VM summary page [WIP] Display IPv6Address on VM summary page May 2, 2017
@simaishi simaishi changed the title [WIP] Display IPv6Address on VM summary page Display IPv6Address on VM summary page May 2, 2017
simaishi pushed a commit that referenced this pull request May 4, 2017
@agrare @simaishi
Merge pull request #13190 from jameswnl/ipv6display
3518744 
Display IPv6Address on VM summary page
(cherry picked from commit 4529df7)

https://bugzilla.redhat.com/show_bug.cgi?id=1448142
https://bugzilla.redhat.com/show_bug.cgi?id=1448140
@simaishi
Copy link
Contributor

simaishi commented May 4, 2017

Euwe backport details:

$ git log -1
commit 3518744c8a0bc6c5b5106f7715ff98f2c3cb88f4
Author: Adam Grare <[email protected]>
Date:   Mon Dec 19 13:01:52 2016 -0500

    Merge pull request #13190 from jameswnl/ipv6display
    
    Display IPv6Address on VM summary page
    (cherry picked from commit 4529df74d0bc38044f2d1155a9527b532f6545f3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1448142
    https://bugzilla.redhat.com/show_bug.cgi?id=1448140

@jameswnl jameswnl deleted the ipv6display branch November 2, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blomquisg blomquisg

@agrare agrare

Labels
bug enhancement euwe/backported providers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jameswnl @miq-bot @Ladas @agrare @imtayadeway @simaishi @blomquisg @chessbyte