Charge only for past hours #13134
Merged
Charge only for past hours #13134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
force-pushed
the
rhbz#1402072
branch
2 times, most recently
from
9347446 to
96c99de
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
Uff. This is gonna be one of the more expensive rebases. People were trying to approach the same problems in different prs, but did not fixed the root cause. Gosh. |
isimluk
force-pushed
the
rhbz#1402072
branch
2 times, most recently
from
75d73ca to
1716f8d
Compare
isimluk
changed the title
|
@miq-bot remove_label wip |
After spending 15 minutes of head scratching.
and fix related rubocop
Otherwise, nobody will ever understand why we have them. Now each file includes single hardcoded datetime and everything else is relative to it. Think about it. That's actually meaning of the specs prescription. The hardcoded values were hardcoded to be relative to other hc values.
For variable_rate, we charge only that much that has been consumed. Perhaps I'll end the service tmrw, I should not be charged in advanced. https://bugzilla.redhat.com/show_bug.cgi?id=1402072
lpichler
approved these changes
Jan 6, 2017
isimluk
changed the title
|
Checked commits isimluk/manageiq@2270d42~...3a678bb with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Added |
|
Thanks! We just need to merge #13419 first. Afterwards this will be easier to rebase. (I still expect conflicts in specs). |
|
Backported to Euwe via #13554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://bugzilla.redhat.com/show_bug.cgi?id=1402072
Imagine, You will terminate your service tomorrow, you should not be charged in advance.
@miq-bot add_label bug, chargeback
@miq-bot assign @gtanzillo