VCpus and Memory for Cloud Providers visual #13124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljesusg
changed the title
|
@miq-bot add_label wip,ui |
aljesusg
force-pushed
the
add_cores_memory_cloud_visual
branch
from
3fc20f6 to
e9c92ee
Compare
kbrock
approved these changes
Dec 12, 2016
| :hardware => FactoryGirl.create(:hardware, | ||
| :cpu1x2, | ||
| :ram1GB), | ||
| :name => "vm_#{i}") |
aljesusg
force-pushed
the
add_cores_memory_cloud_visual
branch
from
e9c92ee to
6f6b015
Compare
|
I did the changes @kbrock Thanks |
aljesusg
changed the title
|
@miq-bot remove_label wip |
kbrock
reviewed
Dec 12, 2016
| @@ -258,7 +258,20 @@ | |||
| context "with virtual totals" do | |||
| before(:each) do | |||
| @ems = FactoryGirl.create(:ems_vmware) | |||
| (1..2).each { |i| FactoryGirl.create(:vm_vmware, :ext_management_system => @ems, :name => "vm_#{i}") } | |||
| (1..2).each { |i| FactoryGirl.create(:vm_vmware, | |||
There was a problem hiding this comment.
looking good
please do not change, but for future reference: 2.times { FactoryGirl.create
|
I can make the change @kbrock, don't worry about it.
|
aljesusg
force-pushed
the
add_cores_memory_cloud_visual
branch
from
6f6b015 to
c83b855
Compare
|
Checked commit aljesusg@c83b855 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
chrisarcand
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change in the visual of Cloud list View of providers, now we can see Total Cores and Total Memory of each Provider of Instances(VMs).
@sergio-ocon, @kbrock is the same than #12758 but in cloud provider list view.