Fixed code to expect keys as strings instead of symbols. #13087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was introduced in ManageIQ#12322, some of the code is common between class schema editor and method editor that caused method editor to break. Fixed any affected spec tests. https://bugzilla.redhat.com/show_bug.cgi?id=1403026
|
Checked commit h-kataria@cd6a672 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
mkanoor
approved these changes
Dec 9, 2016
|
👍 |
chessbyte
pushed a commit
that referenced
this pull request
Dec 9, 2016
Fixed code to expect keys as strings instead of symbols. (cherry picked from commit c3171b8) https://bugzilla.redhat.com/show_bug.cgi?id=1403350
|
Euwe Backport details: $ git log -1
commit c9ce739e73f8c42f5cda8772f12ae02d966a8d52
Author: Madhu Kanoor <[email protected]>
Date: Fri Dec 9 13:43:53 2016 -0500
Merge pull request #13087 from h-kataria/ae_method_editor_fix
Fixed code to expect keys as strings instead of symbols.
(cherry picked from commit c3171b816a7486f3dbf72b1c2661d8cbbb5ba229)
https://bugzilla.redhat.com/show_bug.cgi?id=1403350 |
chessbyte
pushed a commit
that referenced
this pull request
Dec 14, 2016
Fixed code to expect keys as strings instead of symbols. (cherry picked from commit c3171b8) https://bugzilla.redhat.com/show_bug.cgi?id=1403351
|
Darga Backport details: $ git log -1
commit fd7155d0e8e984e489fe787e1a2256110115976b
Author: Madhu Kanoor <[email protected]>
Date: Fri Dec 9 13:43:53 2016 -0500
Merge pull request #13087 from h-kataria/ae_method_editor_fix
Fixed code to expect keys as strings instead of symbols.
(cherry picked from commit c3171b816a7486f3dbf72b1c2661d8cbbb5ba229)
https://bugzilla.redhat.com/show_bug.cgi?id=1403351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was introduced in #12322, some of the code is common between class schema editor and method editor that caused method editor to break.
Fixed any affected spec tests.
https://bugzilla.redhat.com/show_bug.cgi?id=1403026
@mkanoor @gmcculloug please review/merge