Add validation for charts with values #13079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for chart mode 'Values'
when it is removed from selected field
|
Checked commits lpichler/manageiq@22540d6~...474eb16 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@miq-bot assign @mzazrivec |
|
@lpichler is there a BZ for this? |
|
@simaishi No. There isn't. |
simaishi
pushed a commit
that referenced
this pull request
Jan 12, 2017
…h_values Add validation for charts with values (cherry picked from commit f5bb6b7) https://bugzilla.redhat.com/show_bug.cgi?id=1412740
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is adding validation message for chart with values that data column have to be selected in this commit.
Also I added "Nothing selected" to data column in this commit. Then user is forced to select any data column and before fix it was done automatically and selected first numeric field.
For some manipulation with this field in selected fields (removing, adding), variable
@edit[:new][:chart_mode]was not updated properly. So I decided to add "Nothing selected" and clean this variable always and force use to selected data column always when data column is removed.this commit is updating variable
@edit[:new][:chart_mode]when data column is selected.Scenario 1:
To be able selected any data column you have to have selected any numeric field in selected fields in first tab of report definition. But when you will set 'Chart mode' to 'Values' then you were able to save report even if don't have selected any data column.
Scenario 2:
@miq-bot add_label ui, bug, euwe/yes
@miq_bot assign @mzazrivec
cc @PanSpagetka