-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP](Depends on #13060) Dto collection save inventory specs for skeletal refresh #13049
Closed
Ladas
wants to merge
6
commits into
ManageIQ:master
from
Ladas:dto_collection_save_inventory_specs_for_skeletal_refresh
Closed
[WIP](Depends on #13060) Dto collection save inventory specs for skeletal refresh #13049
Ladas
wants to merge
6
commits into
ManageIQ:master
from
Ladas:dto_collection_save_inventory_specs_for_skeletal_refresh
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
force-pushed
the
dto_collection_save_inventory_specs_for_skeletal_refresh
branch
from
December 8, 2016 12:30
2122041
to
a8322d6
Compare
Introduce only_update for a DtoCollection, in the sace where we want to skip all deletes and creates and update only existing records.
Use create_allowed? and update_allowed? when saving Dtos
Refactor comparing method of collections, so we can easily use it when debugging
Ladas
force-pushed
the
dto_collection_save_inventory_specs_for_skeletal_refresh
branch
from
December 8, 2016 14:39
a8322d6
to
4af7048
Compare
Ladas
changed the title
[WIP](Depends on #13018) Dto collection save inventory specs for skeletal refresh
Dto collection save inventory specs for skeletal refresh
Dec 8, 2016
A foreign key can be a part of index of the DtoCollection
Enhance Keypair spec data for a skeletal refresh, so we can separate relations and data
Spec for Dto saving with skeletal strategy
Ladas
force-pushed
the
dto_collection_save_inventory_specs_for_skeletal_refresh
branch
from
December 8, 2016 15:25
15f559b
to
bf4614d
Compare
Ladas
changed the title
Dto collection save inventory specs for skeletal refresh
[WIP](Depends on #13060) Dto collection save inventory specs for skeletal refresh
Dec 8, 2016
Checked commits Ladas/manageiq@808cbaa~...bf4614d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 spec/models/manager_refresh/save_inventory/graph_of_dto_collections_skeletal_refresh_spec.rb
|
This pull request is not mergeable. Please rebase and repush. |
Closing since this has been in conflict for 9 months :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dto collection save inventory specs for skeletal refresh