Filter attempt from the authentication_check options #13026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various implementations of verify_credentials aren't expecting an :attempt => 1 hash key/value. It's only used at a higher layer so exclude it from the authentication_check call. https://bugzilla.redhat.com/show_bug.cgi?id=1402035 This was a regression introduced in ManageIQ#11964
|
Checked commit jrafanie@ab40ebe with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 spec/models/mixins/authentication_mixin_spec.rb
|
|
Added blocker label since this would cause all rhev/ovirt providers to have their authentications fail with an Error. That could cause various workers for these providers to not start if they require valid authentications. |
chessbyte
pushed a commit
that referenced
this pull request
Dec 8, 2016
…ation_check_options Filter attempt from the authentication_check options (cherry picked from commit 786244f) https://bugzilla.redhat.com/show_bug.cgi?id=1402887
|
Euwe Backport details: $ git log -1
commit 1c5ba9dfdf47f149f7f77ae4dcc6f1298e185309
Author: Gregg Tanzillo <[email protected]>
Date: Wed Dec 7 10:40:55 2016 -0500
Merge pull request #13026 from jrafanie/filter_attempt_from_authentication_check_options
Filter attempt from the authentication_check options
(cherry picked from commit 786244f0a911d28cc65fcffdb085375c19242500)
https://bugzilla.redhat.com/show_bug.cgi?id=1402887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various implementations of verify_credentials aren't expecting an
:attempt => 1 hash key/value.
It's only used at a higher layer so exclude it from the
authentication_check call.
https://bugzilla.redhat.com/show_bug.cgi?id=1402035
This was a regression introduced in #11964