Use proper name of column in tooltip in charts #13011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
use_proper_name_for_tooltip_in_charts
branch
2 times, most recently
from
cdae74e to
92260ef
Compare
lpichler
changed the title
|
@miq-bot add_label wip |
lpichler
force-pushed
the
use_proper_name_for_tooltip_in_charts
branch
2 times, most recently
from
99a720c to
e3f3fad
Compare
lpichler
changed the title
|
@PanSpagetka please review |
lpichler
force-pushed
the
use_proper_name_for_tooltip_in_charts
branch
from
6255390 to
379d5c4
Compare
dclarizio
reviewed
Dec 8, 2016
| # determine name column from headers for x-axis in chart | ||
| def chart_header_column | ||
| if graph[:column].blank? | ||
| _log.error("Column for x-axis of chart have to be defined in report") |
There was a problem hiding this comment.
Message text should be The column for the chart's x-axis must be defined in the report.
There was a problem hiding this comment.
👍 thanks @dclarizio
- determine name of column (Header column) from chart column. Name is taken from MiqReport#headers by index. This index is determined from MiqReport#col_order
lpichler
force-pushed
the
use_proper_name_for_tooltip_in_charts
branch
from
379d5c4 to
f002856
Compare
|
Checked commits lpichler/manageiq@99cdbaa~...f002856 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@lpichler is there a BZ for this? |
|
@simaishi No. I found it by myself. |
simaishi
pushed a commit
that referenced
this pull request
Jan 12, 2017
…n_charts Use proper name of column in tooltip in charts (cherry picked from commit d6b146f) https://bugzilla.redhat.com/show_bug.cgi?id=1412738
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was first one taken before it should be taken from Data Column:
before
after
@miq-bot add_label bug, ui, euwe/yes
@miq-bot assign @mzazrivec
please review @PanSpagetka