Add root password validation regex for Azure dialog #12967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip |
|
@lfu Please take a look. |
djberg96
changed the title
|
@miq-bot remove_label wip |
|
Thanks to some diligent work by Lucy, we discovered that the update_field_visibility method in provision_workflow.rb was disabled. By enabling it, the validation works. |
|
@miq-bot add_label euwe/yes |
|
@miq-bot add_label blocker |
chessbyte
pushed a commit
that referenced
this pull request
Dec 6, 2016
Add root password validation regex for Azure dialog (cherry picked from commit 3fe2410) https://bugzilla.redhat.com/show_bug.cgi?id=1402059
|
Euwe Backport details: $ git log -1
commit 0154c024f1e767d189760b305cd4d4dd18f9f1c8
Author: Greg McCullough <[email protected]>
Date: Mon Dec 5 11:37:13 2016 -0500
Merge pull request #12967 from djberg96/service_dialog_root_password
Add root password validation regex for Azure dialog
(cherry picked from commit 3fe2410491c51f6953c2c282cf508c39552f4274)
https://bugzilla.redhat.com/show_bug.cgi?id=1402059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to add password validation for Azure VM admin/root passwords. The password for a VM must be 12-72 characters long, and contain at least one uppercase character, one lowercase character, and one number.
https://bugzilla.redhat.com/show_bug.cgi?id=1377890
Marked as a WIP for now since the UI doesn't seem to honor the required restrictions, even without this PR.