Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give policy event sample reports better names #12934

Merged
merged 1 commit into from
Nov 30, 2016

Conversation

dclarizio
Copy link

Original report names simply had "Sample 1" and "Sample 2" suffixes. Changed these to be more descriptive as one report is for events for last week (Sun through Sat) and the other is for events from the last 7 days.

https://bugzilla.redhat.com/show_bug.cgi?id=1391900

@miq-bot
Copy link
Member

miq-bot commented Nov 30, 2016

Checked commit dclarizio@1e66600 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🍰

@h-kataria h-kataria added this to the Sprint 50 Ending Dec 5, 2016 milestone Nov 30, 2016
@h-kataria h-kataria merged commit 8727594 into ManageIQ:master Nov 30, 2016
@dclarizio dclarizio deleted the fix_policy_event_report_names branch December 1, 2016 16:59
simaishi pushed a commit that referenced this pull request Jan 9, 2017
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2017

Euwe backport details:

$ git log -1
commit 07271791b474d735b33af8521397f8f11bf755fb
Author: Harpreet Kataria <[email protected]>
Date:   Wed Nov 30 18:17:20 2016 -0500

    Merge pull request #12934 from dclarizio/fix_policy_event_report_names
    
    Give policy event sample reports better names
    (cherry picked from commit 8727594fa165aeae61ff4fb86b8eb91933c1a158)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1401017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants