Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display parent tenant only when it is allowed by RBAC #12848

Merged

Conversation

lpichler
Copy link
Contributor

in detail of tenant, we are displaying parent tenant always but displaying parent should restricted by
RBAC

This user is not able to see parent tenant:
before
screen shot 2016-11-24 at 18 18 06

after
screen shot 2016-11-24 at 18 20 20

@miq-bot add_label ui, bug

@lpichler lpichler force-pushed the show_parent_tenant_only_when_it_is_allowed branch from 4e7097b to c98a613 Compare November 28, 2016 08:26
@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2016

Checked commit lpichler@c98a613 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

@mzazrivec mzazrivec self-assigned this Nov 28, 2016
@mzazrivec mzazrivec added this to the Sprint 50 Ending Dec 5, 2016 milestone Nov 28, 2016
@mzazrivec mzazrivec merged commit 82d18ea into ManageIQ:master Nov 28, 2016
@simaishi
Copy link
Contributor

simaishi commented Jan 6, 2017

@lpichler is there a BZ for this?

@lpichler lpichler deleted the show_parent_tenant_only_when_it_is_allowed branch January 9, 2017 12:30
@lpichler
Copy link
Contributor Author

lpichler commented Jan 9, 2017

@simaishi No, I found it by myself.

@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2017

simaishi pushed a commit that referenced this pull request Jan 9, 2017
…it_is_allowed

Display parent tenant only when it is allowed by RBAC
(cherry picked from commit 82d18ea)

https://bugzilla.redhat.com/show_bug.cgi?id=1411459
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2017

Euwe backport details:

$ git log -1
commit 48e5f64276de44520dfc6afcca14531138391095
Author: Milan Zázrivec <[email protected]>
Date:   Mon Nov 28 18:20:13 2016 +0100

    Merge pull request #12848 from lpichler/show_parent_tenant_only_when_it_is_allowed
    
    Display parent tenant only when it is allowed by RBAC
    (cherry picked from commit 82d18eaadd6df099c64ffb4e773482b6fc630806)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1411459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants