-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove cpu total from chargeback report #12829
Conversation
b31330a
to
3118712
Compare
@@ -223,4 +225,20 @@ def remove_loading_relations_for_virtual_custom_attributes | |||
vc_attributes = CustomAttributeMixin.select_virtual_custom_attributes(cols).present? | |||
include.delete(:custom_attributes) if vc_attributes.present? && include && include[:custom_attributes].blank? | |||
end | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lpichler Please add a comment here indicating that these methods are for supporting legacy reports that may have some of the columns that are being removed by this PR in them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment added, but I moved excluding columns to the after_initialize,
because before array operation .push
does not work as I expected.
a = MiqReport.last
a.cols.push("aaa")
3118712
to
53cf211
Compare
ac848ad
to
1a2f993
Compare
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
because there are added MHZs and allocated CPUs together.
1a2f993
to
5e68ceb
Compare
Checked commits lpichler/manageiq@7b3b3ea~...5e68ceb with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
Oh, I thought I have seen that idea before. Sorry for the hijack bro. 🍔 |
because there are added MHz s and counts of cpu cores together.
CPU total cost make sense.
I introduced here b31330a exluding of columns from reports but we can revert it a remove by migration if future.
@miq-bot add_label chargeback, reporting, bug
@miq-bot assign @gtanzillo