Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag visibility for Container Template #12759

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Fix tag visibility for Container Template #12759

merged 1 commit into from
Dec 1, 2016

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Nov 20, 2016 •
edited by miq-bot
Loading

@zakiva
Copy link
Contributor Author

zakiva commented Nov 20, 2016

@miq-bot add_label providers/containers, bug, ui

@simon3z
Copy link
Contributor

simon3z commented Nov 21, 2016

@miq-bot assign zakiva

Overall OK with me. @zakiva try to find a review. Thanks.

@zakiva
Copy link
Contributor Author

zakiva commented Nov 21, 2016

@isimluk @gtanzillo can you please review this?

@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2016

Checked commit zakiva@1ebfb28 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🍪

isimluk
isimluk approved these changes Nov 22, 2016
View reviewed changes
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simon3z
Copy link
Contributor

simon3z commented Nov 22, 2016

LGTM 👍
Ready for merge cc @chessbyte @gtanzillo

@miq-bot assign gtanzillo

@miq-bot miq-bot assigned gtanzillo and unassigned zakiva Nov 22, 2016
@simon3z
Copy link
Contributor

simon3z commented Nov 22, 2016

@miq-bot add_label euwe/yes

@zeari
Copy link

zeari commented Nov 22, 2016

LGTM 👍

@gtanzillo
Copy link
Member

👍

@gtanzillo gtanzillo added this to the Sprint 50 Ending Dec 5, 2016 milestone Dec 1, 2016
@gtanzillo gtanzillo merged commit e0aa649 into ManageIQ:master Dec 1, 2016
@simaishi
Copy link
Contributor

simaishi commented Dec 5, 2016

BZ is marked as blocker

@chessbyte
Copy link
Member

Euwe BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1401559

chessbyte pushed a commit that referenced this pull request Dec 5, 2016
@gtanzillo @chessbyte
Merge pull request #12759 from zakiva/fix_template_tags
0b599ef 
Fix tag visibility for Container Template
(cherry picked from commit e0aa649)

https://bugzilla.redhat.com/show_bug.cgi?id=1401559
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log -1
commit 0b599efd82f7634060599e247944f51a7595ce70
Author: Gregg Tanzillo <[email protected]>
Date:   Thu Dec 1 15:21:10 2016 -0500

    Merge pull request #12759 from zakiva/fix_template_tags
    
    Fix tag visibility for Container Template
    (cherry picked from commit e0aa64947cb8cce50070766916d540ccb936452d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1401559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isimluk isimluk isimluk approved these changes

Assignees

@gtanzillo gtanzillo

Labels
blocker bug euwe/backported providers/containers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zakiva @simon3z @miq-bot @zeari @gtanzillo @simaishi @chessbyte @isimluk