Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Router: Fix angular controller #12707

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Network Router: Fix angular controller #12707

merged 1 commit into from
Nov 21, 2016

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Nov 17, 2016

No description provided.

@miq-bot
Copy link
Member

miq-bot commented Nov 17, 2016

Checked commit https://github.com/gildub/manageiq/commit/e772640afe6ee72fd0b1a25c65b170d6c431f49a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🍪

@himdel himdel added this to the Sprint 50 Ending Dec 5, 2016 milestone Nov 21, 2016
@himdel himdel merged commit a14264e into ManageIQ:master Nov 21, 2016
@himdel
Copy link
Contributor

himdel commented Nov 21, 2016

Thanks @gildub , merging :)

Introduced in #11477, adding euwe/yes

@gildub gildub deleted the network_router-angular-controller-fix branch November 22, 2016 05:03
@simaishi
Copy link
Contributor

@gildub Please create a BZ if it doesn't already exist.

@simaishi
Copy link
Contributor

simaishi commented Jun 6, 2017

@gildub @himdel does this still need to go to Euwe? Is there a BZ?

@himdel
Copy link
Contributor

himdel commented Jun 6, 2017

Looking at this again, maybe we can skip euwe.. This only seems to fix the Cancel button sending all the form data on Cancel, so maybe there's nothing here that would affect the user.

@gildub Am I right? Or, do you remember anything more? (That's what you get for not providing a description ;).)

@gildub
Copy link
Contributor Author

gildub commented Jun 19, 2017

@simaishi, @himdel

Yes we can pass on that one.
Well at the time I didn't have much to describe anyway :).

@himdel
Copy link
Contributor

himdel commented Jun 19, 2017

@simaishi Looks like we can just drop it then.. updating the labels..

@miq-bot remove_label euwe/yes, bugzilla needed
@miq-bot add_label euwe/no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants