Separate Storage Managers By Type in UI #12399

jerryk55 · 2016-11-03T14:28:48Z

Add the ability to show Storage Managers by the type of storage they support.
Add supports_block_storage? and supports_object_storage? methods
and add them to the Cinder and Swift managers, respectively.
Change the UI so that it Shows Block and Object storage and the managers for each
separately.
Make menu and headings for Storage Managers consistent (remove any indication that the
Managers are "Providers").

Block Storage Menus:

Object Storage Menus:

Block Storage Managers:

Object Storage Managers:

Hover Text:

This PR is dependent upon #12310 to add the functionality to let the UI filter items in show_list by the "supports_feature?"

Links

Allow controllers to specify supports? filters #12310

jerryk55 · 2016-11-03T14:49:35Z

@h-kataria @dclarizio @roliveri please review.

jerryk55 · 2016-11-03T14:58:52Z

Rubocop warnings addressed and re-pushed.

jerryk55 · 2016-11-03T19:23:36Z

Tests added and fixed and all have passed. Still waiting for comments from @h-kataria with regard to headings on the list screens but otherwise this could have WIP removed...

jerryk55 · 2016-11-04T17:12:51Z

All issues have been resolved. More tests have been added. Removing the WIP label from the title.
@h-kataria et.all please review and merge - however please mergehttps://github.com//pull/12310 first. Thank you!

miq-bot · 2016-11-04T17:52:17Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

jerryk55 · 2016-11-09T14:20:45Z

@chessbyte was the WIP label added back into the title here automagically or purposefully? I had removed it when I believed the PR ready to merge. Thanks.

jerryk55 · 2016-11-09T14:28:22Z

@h-kataria @roliveri @dclarizio can someone review this - thanks!

jerryk55 · 2016-11-10T13:50:26Z

@miq-bot remove_label wip

dclarizio · 2016-11-10T18:57:45Z

@martinpovolny please review code and for menu/UI guidelines. Thx, Dan

@jerryk55 we'll try to get this reviewed, but it's quite large and we're tackling blockers right now.

jerryk55 · 2016-11-10T19:32:01Z

@dclarizio thanks. @martinpovolny let me know if you have any questions. By the way the Travis failure is a generic issue related to bower. I'm not sure who is working on that issue.

dclarizio · 2016-11-10T22:34:09Z

@jerryk55 I restarted the VMDB tests, they are running green, so will keep an eye on it.

roliveri · 2016-11-11T18:48:07Z

This looks good to me. We may want to include someone on the performance team to evaluate DB access performance, and scaleability.

cc: @dmetzger57

jerryk55 · 2016-11-16T16:46:08Z

Has anyone had a chance to review? @martinpovolny? @dmetzger57? Bueller? It would be nice to have this merged if possible. Thanks.

martinpovolny · 2016-11-28T16:09:50Z

app/controllers/cloud_object_store_container_controller.rb

@@ -62,7 +62,7 @@ def show
  private

  def get_session_data


I wonder if we could use the GenericSessionMixin here instead of having an own method (and altering the way @title is calculated).

@martinpovolny I didn't add this controller or even this method as part of this PR. I only changed the string value of the title.

martinpovolny · 2016-11-28T16:12:23Z

app/controllers/ems_block_storage_controller.rb

@@ -0,0 +1,43 @@
+class EmsBlockStorageController < ApplicationController


guess you need a menu_section line in this controller.

@martinpovolny just curious - what is that supposed to do - the menu code clearly works for me without the line in both the EmsBlockStorageController and EmsObjectStorageController - neither of which have it. Also I've moved some of the menu sections around for these controllers and it appears that there may be other changes needed if this actually has an effect.Thanks.

Never mind that - @h-kataria has explained it to me. I have made the required changes to each controller represented by a modified entry in the Menu::DefaultMenu.

martinpovolny · 2016-11-28T16:14:03Z

app/controllers/ems_object_storage_controller.rb

+  end
+
+  def show_list
+    opts = {:supported_features_filter => "supports_object_storage?",


I am going to force the use of GenericListMixin for all the show_list implementations one by one. So would be nice if you could follow that pattern but I understand that you are following another pattern here and it's hard to tell which one to choose :-(

So I can fix this later on.

martinpovolny · 2016-11-28T16:17:48Z

w/o the menu_section remembering URLs for tabs will not work for the newly added controller actions. https://github.com/ManageIQ/guides/blob/master/ui/menus.md#remembering-last-clicks

Overall the code looks good.

Do we have a volunteer to run this in the UI and check if there are any problem?

h-kataria · 2016-11-28T20:42:43Z

@martinpovolny i have a db from @jerryk55 i am going to test it in UI.

jerryk55 · 2016-11-30T21:50:24Z

The latest commit has been added to resolve several issues discovered by @h-kataria during testing.

1. Add the ability to show Storage Managers by the type of storage they support. 2. Add supports_block_storage? and supports_object_storage? methods and add them to the Cinder and Swift managers, respectively. 3. Change the UI so that it Shows Block and Object storage and the managers for each separately. 4. Make menu and headings for Storage Managers consistent (remove any indication that the Managers are "Providers").

Fix all Rubocop warnings for this PR. Note tthat warnings for app/views/ems_block_storage/*.haml and app/views/ems_object_storage/*.haml will not be addressed since the code is consistent with many other examples in app/views.

Add tests for the new menus for Block Storage and Object Storage.

Final functional commit for this PR fixes the list headings for the Object and Block Storage Managers. Additionally it adds in the center toolbars and the proper hover over text on the toolbar menus.

Add tests for show_list functionality of Block and Object Storage Manager Controllers.

…Menu Each controller representing a MenuItem in the Menu::DefaultMenu now contains a menu_section directive indicating the MenuSection in which it is located. Some of these need to be changed and some added due to modifications in this PR.

This commit addresses the following issues discovered during testing of this PR: 1) The Block Storage Manager's Relationships Accordion failed to open. It should contain a link to the Cloud Volumes for the Manager. 2) Both the Properties Accordion's link to the Timeline as well as the drop-down Monitoring menu item for the Timeline were not grayed out when there are not any events for the Storage Manager.

The default menu list items for the Block and Object Storage Managers each were set to be selected when the "StorageManager" controller was run, which occurs when one of the storage managers has its detailed info displayed. The menu was updated to the correct controllers.

miq-bot · 2016-11-30T22:52:50Z

jerryk55 · 2016-11-30T22:53:37Z

This final (hopefully) commit fixes an issue that resulted in the Storage Manager AND Object Manager menu items being selected when the detailed info was displayed for any one of either of these managers. Incorrect entries in the default menu pointing to the storage_manager controller caused this. All issues discovered by @h-kataria during testing have been resolved. This is ready to go after final review. Thanks all!

h-kataria · 2016-12-01T18:36:57Z

Tested in UI, looks good.

chessbyte added enhancement wip ui providers/storage labels Nov 3, 2016

jerryk55 force-pushed the additional_storage_manager_menu_level branch from c98f728 to 9d8327a Compare November 3, 2016 14:58

jerryk55 mentioned this pull request Nov 3, 2016

Allow controllers to specify supports? filters #12310

Merged

jerryk55 force-pushed the additional_storage_manager_menu_level branch from 9d8327a to 0231389 Compare November 3, 2016 17:44

jerryk55 force-pushed the additional_storage_manager_menu_level branch from a052de2 to 795f39e Compare November 4, 2016 17:11

jerryk55 changed the title ~~[WIP] Separate Storage Managers By Type in UI~~ Separate Storage Managers By Type in UI Nov 4, 2016

chessbyte changed the title ~~Separate Storage Managers By Type in UI~~ [WIP] Separate Storage Managers By Type in UI Nov 4, 2016

jerryk55 changed the title ~~[WIP] Separate Storage Managers By Type in UI~~ Separate Storage Managers By Type in UI Nov 9, 2016

jerryk55 force-pushed the additional_storage_manager_menu_level branch 2 times, most recently from 782e7af to 7c17428 Compare November 10, 2016 13:48

miq-bot removed the wip label Nov 10, 2016

chessbyte assigned dclarizio Nov 10, 2016

jerryk55 force-pushed the additional_storage_manager_menu_level branch from 7c17428 to 81ec9d2 Compare November 17, 2016 15:14

martinpovolny reviewed Nov 28, 2016

View reviewed changes

jerryk55 force-pushed the additional_storage_manager_menu_level branch from 81ec9d2 to 16a17e0 Compare November 28, 2016 19:13

jerryk55 force-pushed the additional_storage_manager_menu_level branch from 16a17e0 to 7429b02 Compare November 30, 2016 21:46

jerryk55 added 9 commits November 30, 2016 17:51

Fix Rubocop Warnings

8208bbb

Fix all Rubocop warnings for this PR. Note tthat warnings for app/views/ems_block_storage/*.haml and app/views/ems_object_storage/*.haml will not be addressed since the code is consistent with many other examples in app/views.

Fix Spec Failures for Storage Controllers and Default Menu

67fd132

Add Tests for new Block and Object Storage Menus

f144318

Add tests for the new menus for Block Storage and Object Storage.

Fix show_list Header, toolbars, and hover text

4a2f7c1

Final functional commit for this PR fixes the list headings for the Object and Block Storage Managers. Additionally it adds in the center toolbars and the proper hover over text on the toolbar menus.

Tests for Object And Block Storage Manager Controllers

4840990

Add tests for show_list functionality of Block and Object Storage Manager Controllers.

jerryk55 force-pushed the additional_storage_manager_menu_level branch from 7429b02 to df6f056 Compare November 30, 2016 22:51

h-kataria added this to the Sprint 50 Ending Dec 5, 2016 milestone Dec 1, 2016

h-kataria merged commit 3c8c968 into ManageIQ:master Dec 1, 2016

h-kataria added the euwe/no label Dec 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate Storage Managers By Type in UI #12399

Separate Storage Managers By Type in UI #12399

jerryk55 commented Nov 3, 2016 •

edited

Loading

jerryk55 commented Nov 3, 2016

jerryk55 commented Nov 3, 2016

jerryk55 commented Nov 3, 2016

jerryk55 commented Nov 4, 2016

miq-bot commented Nov 4, 2016

jerryk55 commented Nov 9, 2016

jerryk55 commented Nov 9, 2016

jerryk55 commented Nov 10, 2016

dclarizio commented Nov 10, 2016

jerryk55 commented Nov 10, 2016

dclarizio commented Nov 10, 2016

roliveri commented Nov 11, 2016

jerryk55 commented Nov 16, 2016

martinpovolny Nov 28, 2016

jerryk55 Dec 1, 2016

martinpovolny Nov 28, 2016

jerryk55 Nov 28, 2016 •

edited

Loading

jerryk55 Nov 28, 2016

martinpovolny Nov 28, 2016

jerryk55 Nov 28, 2016

martinpovolny commented Nov 28, 2016 •

edited

Loading

h-kataria commented Nov 28, 2016

jerryk55 commented Nov 30, 2016 •

edited

Loading

miq-bot commented Nov 30, 2016

jerryk55 commented Nov 30, 2016

h-kataria commented Dec 1, 2016

		@@ -0,0 +1,43 @@
		class EmsBlockStorageController < ApplicationController

Separate Storage Managers By Type in UI #12399

Separate Storage Managers By Type in UI #12399

Conversation

jerryk55 commented Nov 3, 2016 • edited Loading

Links

jerryk55 commented Nov 3, 2016

jerryk55 commented Nov 3, 2016

jerryk55 commented Nov 3, 2016

jerryk55 commented Nov 4, 2016

miq-bot commented Nov 4, 2016

jerryk55 commented Nov 9, 2016

jerryk55 commented Nov 9, 2016

jerryk55 commented Nov 10, 2016

dclarizio commented Nov 10, 2016

jerryk55 commented Nov 10, 2016

dclarizio commented Nov 10, 2016

roliveri commented Nov 11, 2016

jerryk55 commented Nov 16, 2016

martinpovolny Nov 28, 2016

Choose a reason for hiding this comment

jerryk55 Dec 1, 2016

Choose a reason for hiding this comment

martinpovolny Nov 28, 2016

Choose a reason for hiding this comment

jerryk55 Nov 28, 2016 • edited Loading

Choose a reason for hiding this comment

jerryk55 Nov 28, 2016

Choose a reason for hiding this comment

martinpovolny Nov 28, 2016

Choose a reason for hiding this comment

jerryk55 Nov 28, 2016

Choose a reason for hiding this comment

martinpovolny commented Nov 28, 2016 • edited Loading

h-kataria commented Nov 28, 2016

jerryk55 commented Nov 30, 2016 • edited Loading

miq-bot commented Nov 30, 2016

jerryk55 commented Nov 30, 2016

h-kataria commented Dec 1, 2016

jerryk55 commented Nov 3, 2016 •

edited

Loading

jerryk55 Nov 28, 2016 •

edited

Loading

martinpovolny commented Nov 28, 2016 •

edited

Loading

jerryk55 commented Nov 30, 2016 •

edited

Loading