Remove extra comma in remote_console.rb #12354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 37d1784 that moved the initialization code of host_address in RemoteConsole#remote_console_acquire_ticket left the comma in a place that caused the `host_address` to be initailized with an array `[host_address, port]` instead of `host_address` which in turn caused the WebsocketProxy to break (connecting to invalid address).
|
Checked commit matobet@d20962f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@miq-bot add_label euwe/yes |
|
@miq-bot add_label blocker |
chessbyte
pushed a commit
that referenced
this pull request
Nov 4, 2016
Remove extra comma in remote_console.rb (cherry picked from commit 81d9f00)
|
Euwe Backport details: $ git log -1
commit 9b9bc38c6f3e6488f3043ba3649eb35c9a2492ff
Author: Martin Povolny <[email protected]>
Date: Wed Nov 2 17:04:18 2016 +0100
Merge pull request #12354 from matobet/fix-console-host-address
Remove extra comma in remote_console.rb
(cherry picked from commit 81d9f000e0d5ba72eb6c05f1c18b3d084c0b9c02) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 37d1784 that moved the initialization
code of host_address in RemoteConsole#remote_console_acquire_ticket left the
comma in a place that caused the
host_addressto be initailized with an array[host_address, port]instead ofhost_addresswhich in turn caused theWebsocketProxy to break (connecting to invalid address).