Display name of a filter in Infrastructure Providers

[hstastna]

fixing issue #12199

Display name of a choosen filter from My Filters which
was not displayed in Compute -> Infrastructure -> Providers
and also in many other places.

Before

After

[hstastna]

@miq-bot add_label bug, ui

[mzazrivec]

While the fix shown would fix the problem at hand, the real problem here is that the search
filter is not being correctly extracted (and set) earlier in the code in
https://github.com/ManageIQ/manageiq/blob/master/app/controllers/application_controller/filter.rb#L533

This broke with commit a014ce4 which changed the expression stored in session from a hash
to a new object (struct). Since the new object doesn't support fetch_path(), it would always
return nil here.

@hstastna please reach out to @isimluk and try to hash out a nice solution for this problem.

[hstastna]

@mzazrivec @isimluk what about
@edit[:expression].selected[:description]
instead of
@edit.fetch_path(@expkey, :selected, :description)
in https://github.com/ManageIQ/manageiq/blob/master/app/controllers/application_controller/filter.rb#L533 ?
(and def adv_search_set_text would be the same as before
https://github.com/ManageIQ/manageiq/blob/master/app/controllers/application_controller/filter.rb#L1011)
For me it works.

[isimluk]

I am sorry, I introduced this problem in a014ce4.

I didn't think of fetch_path as of something MiQ defines only for some of the base data structures. Here are my notes from the analysis

• fetch_path is our custom method defined for Arrays and Hashes (in more_core_extensions)
• fetch_path is lenient. That means when it finds a nil, it will returns nil. While [:x][:y][:z] will blow up 💣
• by replacing Hash with Struct in a014ce4 I broke all the statements that use fetch_path over this Expression 😭
• You can see find some them with git grep edit.fetch_path.*exp[kr]
• This pr potentially fixes one of the problems (although this also inserts a 💣 prepared to detonate 🔥 once either @edit[:expression] or @edit[:expression].selected is nil).
• We don't know if these can be nil -> (A) perhaps fetch_path was used, because there can be nil. (B) perhaps fetch_path was used, because it gave author that cool feeling. 🍸
• I suggest that we plug all the problems (of git grep edit.fetch_path.*exp[kr]) by introducing fetch_path method on the Expression class.
• That can be achieved by ApplicationController::Filter::Expression.send(:include, MoreCoreExtensions::Shared::Nested)

We can try:

    ApplicationController::Filter::Expression.send(:include, MoreCoreExtensions::Shared::Nested)
    x = {:a => ApplicationController::Filter::Expression.new}
    x.fetch_path(:a, :selected, :HEHE)
=> nil
    x[:a].selected[:HEHE]
NoMethodError: undefined method `[]' for nil:NilClass

I think we can fix this bug, by the one liner:

ApplicationController::Filter::Expression.send(:include, MoreCoreExtensions::Shared::Nested)

and then we can continue with extracting code manipulating expression to this class (on my todo list, but I could use some help). When we extract code manipulating Expression to the Expression class, most of the need for fetch_path method will go way. I am willing to bet real money on that.

[hstastna]

For me it works if I add
ApplicationController::Filter::Expression.send(:include, MoreCoreExtensions::Shared::Nested)
to app/controllers/application_controller/filter/expression.rb
so I am fine with this solution.

[mzazrivec]

@hstastna @isimluk I'm also OK with the solution proposed above.

[hstastna]

@mzazrivec I made changes and repushed so it can be merged

[isimluk]

@hstastna the failure is not related to this pr.

You don't need to be admin to restart travis. You can restart travis, by either rebasing this pr, or simply touching that commit. i.e amending the date...

[miq-bot]

Checked commit hstastna@410ed57 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐