Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memory store for assets in test environment #12277

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Use memory store for assets in test environment #12277

merged 1 commit into from
Oct 28, 2016

Conversation

djberg96
Copy link
Contributor

This is an attempt to resolve sporadic test failures caused by the Azure specs. This appears to be a race condition caused by the clear_caches method that is being called within the specs, which then tries to clear the asset cache.

By altering the store, I'm hoping to avoid the issue altogether.

@miq-bot
Copy link
Member

miq-bot commented Oct 28, 2016

Checked commit https://github.com/djberg96/manageiq/commit/9c3d2b309ec83e223f4f565fd1412536e4a2a06d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍰

@jrafanie jrafanie added this to the Sprint 49 Ending Nov 14, 2016 milestone Oct 28, 2016
@jrafanie jrafanie self-assigned this Oct 28, 2016
@jrafanie jrafanie merged commit ff9564d into ManageIQ:master Oct 28, 2016
chessbyte pushed a commit that referenced this pull request Nov 1, 2016
Use memory store for assets in test environment
(cherry picked from commit ff9564d)
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log -1
commit f1d8751290181d65d0a4fbc416be6d008e778fd2
Author: Joe Rafaniello <[email protected]>
Date:   Fri Oct 28 13:28:19 2016 -0400

    Merge pull request #12277 from djberg96/asset_caching

    Use memory store for assets in test environment
    (cherry picked from commit ff9564df94f0703b3520f2aa10ce0791dd4aebe6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants