Validate CPU and Memory Hot-Plug settings in reconfigure

[agrare]

This validates a number of cases related to reconfigure on powered-on VMs that would lead to sometimes cryptic VMware error messages.

The cases covered are:

1. Adding CPUs to a running VM that doesn't have CPU hot-add enabled
   
2. Removing CPUs from a running VM
   
3. Changing the number of cores per sockets on a running VM
   
4. Adding memory to a running VM that doesn't have memory hot-add enabled
   
5. Removing memory from a running VM
   
6. Adding more than the memory hot-add limit to a running VM
   

https://bugzilla.redhat.com/show_bug.cgi?id=1386843

[agrare]

@gmcculloug is this a good place to do this type of validation?

[gmcculloug]

Yes, I think this makes sense. @lfu Please review.

[agrare]

Thanks @gmcculloug , added some spec tests and taking out of WIP

[agrare]

Linking another BZ to this PR https://bugzilla.redhat.com/show_bug.cgi?id=1396631

[lfu]

@agrare What is this change for?

[agrare]

That was so I didn't have to override the default options when I wanted to test just memory or just cpu, I just set it to match https://github.com/agrare/manageiq/blob/a908c662e367e695a58e365550bce7f769b0058f/spec/models/manageiq/providers/vmware/infra_manager/vm/reconfigure_spec.rb#L65

If you look at the rest of the changes in that commit I was able to remove a bunch of code that set the options to the current value, for example a908c66#diff-fafec56c2822f5c78227a8a11313bc6fL124

[lfu]

LGTM other than the minor question

[agrare]

This depends on #12145 which had a sql migration so setting this to euwe/no

[miq-bot]

Checked commits agrare/manageiq@4783ce6~...0110761 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
3 files checked, 10 offenses detected

app/models/manageiq/providers/vmware/infra_manager/vm/reconfigure.rb

• ❕ - Line 53, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for validate_config_spec is too high. [39.33/20]
• ❕ - Line 53, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for validate_config_spec is too high. [14/6]
• ❕ - Line 53, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for validate_config_spec is too high. [14/7]
• ❕ - Line 60, Col 121 - Metrics/LineLength - Line is too long. [152/120]
• ❕ - Line 61, Col 121 - Metrics/LineLength - Line is too long. [155/120]
• ❕ - Line 62, Col 121 - Metrics/LineLength - Line is too long. [136/120]
• ❕ - Line 68, Col 121 - Metrics/LineLength - Line is too long. [150/120]
• ❕ - Line 69, Col 121 - Metrics/LineLength - Line is too long. [159/120]
• ❕ - Line 70, Col 121 - Metrics/LineLength - Line is too long. [123/120]

spec/models/manageiq/providers/vmware/infra_manager/vm/reconfigure_spec.rb

• ❕ - Line 114, Col 121 - Metrics/LineLength - Line is too long. [123/120]

[agrare]

@gmcculloug can this be merged?

[gmcculloug]

It can! Thanks.