Raise an error if a region is not configured for central admin #12264
Conversation
Now when someone tries to do something with an object that belongs to a remote region and hasn't configured the authentication key yet for that region they will get a clear error message. https://bugzilla.redhat.com/show_bug.cgi?id=1389536
|
Checked commits carbonin/manageiq@505dcd2~...d08652d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 spec/models/mixins/inter_region_api_method_relay_spec.rb
|
| let(:region_seq_start) { ApplicationRecord.rails_sequence_start } | ||
| let(:request_user) { "test_user" } | ||
| let(:api_connection) { double("ManageIQ::API::Client connection") } | ||
| let(:region_auth_token) { double("MiqRegion API auth token") } | ||
|
|
||
| before do | ||
| FactoryGirl.create(:miq_region, :region => ApplicationRecord.my_region_number) | ||
| expect(MiqRegion).to receive(:find_by).with(:region => region_number).and_return(region) |
There was a problem hiding this comment.
Do you even need this line? Doesn't 168 and 169 take care of that naturally?
There was a problem hiding this comment.
I thought so too, but the object returned from FactoryGirl.create and the one returned by MiqRegion.find_by are different instances so I can't use the region defined by the let for expects without doing this.
If that's not what's going on, I agree, I would much rather not have this here 😄
There was a problem hiding this comment.
Ahh when I remove this, specs fail because unless you have a region file it'll be region 0 (invalid), makes sense I suppose. ¯_(ツ)_/¯
| let(:region_seq_start) { ApplicationRecord.rails_sequence_start } | ||
| let(:request_user) { "test_user" } | ||
| let(:api_connection) { double("ManageIQ::API::Client connection") } | ||
| let(:region_auth_token) { double("MiqRegion API auth token") } | ||
|
|
||
| before do | ||
| FactoryGirl.create(:miq_region, :region => ApplicationRecord.my_region_number) | ||
| expect(MiqRegion).to receive(:find_by).with(:region => region_number).and_return(region) |
There was a problem hiding this comment.
Ahh when I remove this, specs fail because unless you have a region file it'll be region 0 (invalid), makes sense I suppose. ¯_(ツ)_/¯
…nfigured_regions Raise an error if a region is not configured for central admin (cherry picked from commit 650c968) https://bugzilla.redhat.com/show_bug.cgi?id=1390405
|
Euwe Backport details: $ git log -1
commit 047b557007cadf9b4333ab8568562824d62ebeb0
Author: Chris Arcand <[email protected]>
Date: Fri Oct 28 10:01:22 2016 -0400
Merge pull request #12264 from carbonin/raise_for_api_calls_to_non_configured_regions
Raise an error if a region is not configured for central admin
(cherry picked from commit 650c968e99579d8ba3da04b8e3dc68645ac91368)
https://bugzilla.redhat.com/show_bug.cgi?id=1390405 |
Now when someone tries to do something with an object that belongs to a remote region and hasn't configured the authentication key yet for that region, they will get a clear error message.
Previously the error was
Error caught: [NoMethodError] undefined method '[]' for false:FalseClasswhich is not very helpful.https://bugzilla.redhat.com/show_bug.cgi?id=1389536
@bdunne please review