In dev, warn and exit if cable.yml and db yml are missing #12100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
approved these changes
Oct 21, 2016
|
Good call @skateman, I'll add that. |
bin/setup is responsible for automatically copying these files. Since you could intentionally remove them, we'll just warn in bin/update.
jrafanie
force-pushed
the
warn_on_missing_cable_yml
branch
from
797740a to
6851c70
Compare
jrafanie
changed the title
jrafanie
commented
Oct 21, 2016
| chdir APP_ROOT do | ||
| # This script is a way to update your development environment automatically. | ||
| # Add necessary update steps to this file. | ||
| dev_warn_and_exit_if_missing('config/cable.yml', 'config/cable.yml.sample') | ||
| dev_warn_and_exit_if_missing('config/database.yml', 'config/database.pg.yml') |
There was a problem hiding this comment.
Who knows, it's easy enough to help fix issues before someone embarrasses themselves?
|
Checked commit jrafanie@6851c70 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/setup is responsible for automatically copying these files.
Since you could intentionally remove them, we'll just warn in bin/update.