Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for container performance reports #11904

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Add option for container performance reports #11904

merged 1 commit into from
Jan 5, 2017

Conversation

zeari
Copy link

@zeari zeari commented Oct 13, 2016 •
edited by miq-bot
Loading

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1376377

Added ContainerPerformance, ContainerProjectPerformance, ContainerGroupPerformance, ContainerNodePerformance.

screencapture-localhost-3000-report-explorer-1476371764097

cc @simon3z
@miq-bot add_label providers/containers, reporting

@zeari zeari force-pushed the vim_performance_container branch from 3e0154c to f06829c Compare October 13, 2016 15:18
@zeari
Copy link
Author

zeari commented Dec 15, 2016

@miq-bot add_label euwe/yes
(Z-stream)

@zeari zeari force-pushed the vim_performance_container branch from f06829c to fac3f3c Compare December 22, 2016 11:41
@miq-bot
Copy link
Member

miq-bot commented Dec 22, 2016

Checked commit zeari@fac3f3c with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
5 files checked, 1 offense detected

lib/miq_expression.rb

@zeari
Copy link
Author

zeari commented Dec 22, 2016

@simon3z I think this is ready for merge

@simon3z
Copy link
Contributor

simon3z commented Dec 22, 2016

@zeari yes I agree. LGTM 👍 ready for merge cc @chessbyte @gtanzillo

@miq-bot assign chessbyte

@miq-bot miq-bot assigned chessbyte and unassigned simon3z Dec 22, 2016
@chessbyte chessbyte assigned gtanzillo and unassigned chessbyte Jan 5, 2017
@zeari
Copy link
Author

zeari commented Jan 5, 2017

ping @chessbyte @gtanzillo

gtanzillo
gtanzillo approved these changes Jan 5, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 5, 2017
@gtanzillo gtanzillo merged commit d379d4c into ManageIQ:master Jan 5, 2017
simaishi pushed a commit that referenced this pull request Jan 11, 2017
@gtanzillo @simaishi
Merge pull request #11904 from zeari/vim_performance_container
9ac3f85 
Add option for container performance reports
(cherry picked from commit d379d4c)

https://bugzilla.redhat.com/show_bug.cgi?id=1412383
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 9ac3f851f2e474e62c83509154ddc3ab48257cf6
Author: Gregg Tanzillo <[email protected]>
Date:   Thu Jan 5 09:52:43 2017 -0500

    Merge pull request #11904 from zeari/vim_performance_container
    
    Add option for container performance reports
    (cherry picked from commit d379d4c7c30437a0702b992a8e36077dbb69ad6c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1412383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
core/reporting enhancement euwe/backported providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zeari @miq-bot @simon3z @simaishi @gtanzillo @chessbyte