Moving some of redhat/infra_manager code to separate model

[borod108]

This is just a small step in the direction of making this more object oriented, for now are least this cosmetic change is done to help work on another PR.

[borod108]

@miq-bot add_label "refactoring"
@miq_bot assign @durandom

[miq-bot]

@borod108 Cannot apply the following label because they are not recognized: "refactoring"

[durandom]

@miq-bot add_label refactoring, providers, providers/rhevm

@borod108 you are missing the include_concern "ApiIntergration"

[durandom]

@miq-bot assign durandom

[borod108]

@durandom oh thank you for catching this, I added that line and the did some more changes and removed it by mistake...

[borod108]

@durandom can we merge this please? all the rubocop are for old code.

[Fryguy]

@durandom Are you good with this?

[durandom]

@Fryguy yeah, once CI is 🍏 I'm good

And I trust @borod108 that he just copied the methods - did not check line by line :)

[Fryguy]

Tests are 🔴 😕

@durandom Is this a pattern we should do in the other providers to keep them consistent (i.e. create an ApiIntegration concern)?

[durandom]

Is this a pattern we should do in the other providers to keep them consistent (i.e. create an ApiIntegration concern)?

No, in the end it's a decision to be made the providers' author. In this case it makes sense, because they do quite some Api introspection. Whereas, say for amazon, the api integration is just the connect method.

We made this, in order to make the follow up PR focus only on the changing part not the moving of methods part.

ps. I'd be great to have all the Manager subclasses only implement the methods required by its base class. So, moving this to a concern and maybe later to its own class sounds like the right direction to me.

[durandom]

@borod108 does the test fail also locally for you?

[miq-bot]

Checked commit borod108@2bc6c56 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 14 offenses detected

app/models/manageiq/providers/redhat/infra_manager/api_integration.rb

• ⚠️ - Line 121, Col 3 - Lint/RescueException - Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
• ❗ - Line 124, Col 5 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 129, Col 23 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 1, Col 1 - Metrics/ModuleLength - Module has too many lines. [182/100]
• ❗ - Line 5, Col 39 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 89, Col 7 - Style/MultilineMethodCallIndentation - Align .try with connection_configuration_by_role('metrics') on line 88.
• ❗ - Line 90, Col 7 - Style/MultilineMethodCallIndentation - Align .try with connection_configuration_by_role('metrics') on line 88.
• ❕ - Line 104, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for verify_credentials_for_rhevm_metrics is too high. [23.15/20]
• ❕ - Line 104, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for verify_credentials_for_rhevm_metrics is too high. [7/6]
• ❕ - Line 174, Col 23 - Metrics/ParameterLists - Avoid parameter lists longer than 5 parameters.
• ❕ - Line 192, Col 23 - Metrics/ParameterLists - Avoid parameter lists longer than 5 parameters.
• ❕ - Line 4, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for connect is too high. [29.6/20]
• ❕ - Line 4, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for connect is too high. [11/6]
• ❕ - Line 4, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for connect is too high. [11/7]

[borod108]

@durandom no it was passing locally, anyway I fetched and rebased on master and now its green.

[durandom]

@Fryguy it's green. Can you merge in case you have no objections?

[chessbyte]

Euwe Backport details:

$ git log
commit fd81918d7640995d5d79d43655c058f72a8b9e8b
Author: Jason Frey <[email protected]>
Date:   Mon Sep 26 16:22:20 2016 -0400

    Merge pull request #11482 from borod108/ref/split_api_integration_from_infra_manager

    Moving some of redhat/infra_manager code to separate model
    (cherry picked from commit 7988378a22971254d7e5eea1a8070280801dd957)