Do not use &. notation just yet #10663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to support Ruby 2.2.2 notation.
|
Checked commit isimluk@1a8e36d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@jrafanie Is the 2.2.2+ ruby version requirement still true? If so, I'm inclined to merge this PR. |
|
@miq-bot add_label darga/no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As per developer_setup.md we support Ruby 2.2.2+. Thus, until we change this guide we need to write code that complies with Ruby 2.2.2.
The abuse was introduced in #10218. /cc @romanblanco. I am guilty of discussing this with @mzazrivec and not noticing this problem during the review.
@miq-bot assign @mzazrivec
@miq-bot add_label ui, bug