Restrict relative datetime handling to operators that support them in MiqExpression#to_ruby #10295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits imtayadeway/manageiq@b81528a~...396c2ed with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
👍 |
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Dec 2, 2016
…ect operator "after" That operator was removed for date/time fields in ManageIQ#10295 https://bugzilla.redhat.com/show_bug.cgi?id=1400330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Companion to #10246 and #9960. Does the same in the
#to_rubypath that we did in those PRs for#to_sql, i.e. only handle relative datetimes in operators that officially support them.@miq-bot add-label core, technical debt, refactoring
@miq-bot assign @gtanzillo