ActsAsArModel supports more report and rbac use cases

[kbrock]

BLOCKED ON: #10273

Screens that display ActsAsArModel are broken. There are a few steps to merge:

• Remove references to apply_legacy_finder_options - part 1 #10264 remove references to apply_legacy_finder_options
• Remove apply_legacy_finder_option methods #10175 remove apply_legacy_finder_options (calling on query blew things up)
• Enhance ActsAsArQuery for reports #10273 Fix includes for reports
• This PR (1 commit) - add a test to ensure ActsAsArModel works for basic cases

Fixes #10087

Details:

1. Support includes(:table => {}) (an similar references / order). It is not smart enought to properly the second level of hashes. but :includes is not really supported by our ActsAsArModel implementations.
2. Support references(:table => {}). Though we do not use :references in any of our implementations, it was blowing up before. it was free with the includes() implementation
3. Support order(Hash). It was free. We may need to support other syntaxes for this as well.
4. Support length attribute, which is essentially the same as size
5. Support where(nil) which is getting called more often now that we are sql munging less.

/cc @lucasponce

[Fryguy]

This ends up calling to_class twice (once on line 177) and then again here. Is that expected?

[kbrock]

to_class takes a string and calls constantize on it. If a class is passed in, it is a no-op.

I want just this call, but wasn't able to delete line 177 yet.

[kbrock]

I'll remove this call to make more clear

[kbrock]

@Fryguy changed the naming a bit. added some comments and added a test class here too to show what is happening.

I tried to update the changes your suggested.

If you note, the blocked PRs are at the beginning of the commit list, but this PR is only 1 commit. and should be pretty close to the original PR that you reviewed.

[kbrock]

rebased with fixes to other PR. (you can see green dots in commit lists

[miq-bot]

Checked commit kbrock@7d8baed with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🍪

[kbrock]

@Fryguy unblocked. not sure if you have any further comments

[lucasponce]

Hi, is there any ETA when all the PRs related to ActsAsArModel changes will be merged ?
After they are in we should validate if we need to perform additional changes on the provider side.
Any info would be welcome :).
/cc @kbrock @abonas