Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event filters into the database #3273

Closed
gmcculloug opened this issue Jun 25, 2015 · 0 comments
Closed

Move event filters into the database #3273

gmcculloug opened this issue Jun 25, 2015 · 0 comments

Comments

@gmcculloug
Copy link
Member

Event Filtering

Goals

Move the event filters out of the existing yaml file and into centralized database. Support granular filtering at provider level.

Phase 1

  1. Move event filters out of the configuration file (event_handling.tmpl.yml) and into a new database table.
  2. Allow filters to be defined for providers:
    1. By Model Type (based on type field from ext_management_system table)
    2. By provider instance
  3. Signal event catcher worker to update filter list after changes.
  4. Support CRUD operations from UI

Phase 2

  1. Filter events based on tags
  2. Display provider events by counts over a time range (1 hour, 1 day, 1 week) and support adding events to filter list.
  3. Support option to record events but do not process.
  4. Support wildcard/regex filter definitions

Initial thoughts on Phase 1 changes

  • Create new database table event_filters
    • event_name
    • provider_id
    • provider_model
    • enabled
    • timestamps
  • Add seed method for event_filters to populate new table if empty
  • Add has_many relationship from provider to event_filters with dependent => destroy
  • Add method event_catcher_filters to provider model that returns all provider model and provider instance filter events.
  • Change event catcher worker to use event_catcher_filters instead of reading yaml file
  • Remove existing filter logic from ems_event.rb
lfu added a commit to lfu/manageiq that referenced this issue Aug 12, 2015
lfu added a commit to lfu/manageiq that referenced this issue Aug 12, 2015
lfu added a commit to lfu/manageiq that referenced this issue Aug 12, 2015
lfu added a commit to lfu/manageiq that referenced this issue Aug 12, 2015
…ation into BlacklistedEvents.

Only user added events will be migrated.
The system events will be added during seeding.
Fix ManageIQ#3273.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants