Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dialog support for import/export of custom buttons #20124

Closed
borisko123 opened this issue May 4, 2020 · 0 comments · Fixed by #20137
Closed

add dialog support for import/export of custom buttons #20124

borisko123 opened this issue May 4, 2020 · 0 comments · Fixed by #20137
Labels
enhancement help wanted

Comments

@borisko123
Copy link
Contributor

borisko123 commented May 4, 2020 •
edited
Loading

Custom button may have relation to dialog.
Currently, import/export custom buttons code does not take the related dialog into account.
Also, imported buttons may be updated.
borisko123 added a commit to borisko123/manageiq that referenced this issue May 7, 2020
@borisko123
add dialog info when import/export custom buttons
6e636c2 
Isuue#ManageIQ#20124
@borisko123 borisko123 mentioned this issue May 8, 2020
Merged
borisko123 added a commit to borisko123/manageiq that referenced this issue May 24, 2020
@borisko123
-Issue ManageIQ#20124
ff8ea1b 
-fix error in spec example
-the test result depends on file order
-code style review
-modified according to miq-bot request
-fix rubocop offence
-add new flag (for dialog), modify specs
- after review, simplify export dialog, Tempfile creation
borisko123 added a commit to borisko123/manageiq that referenced this issue May 24, 2020
@borisko123
-Issue ManageIQ#20124
d034b34 
-fix error in spec example
-the test result depends on file order
-code style review
-modified according to miq-bot request
-fix rubocop offence
-add new flag (for dialog), modify specs
- after review, simplify export dialog, Tempfile creation
borisko123 added a commit to borisko123/manageiq that referenced this issue May 25, 2020
@borisko123
-Issue ManageIQ#20124
7069262 
-fix error in spec example
-the test result depends on file order
-code style review
-modified according to miq-bot request
-fix rubocop offence
-add new flag (for dialog), modify specs
- after review, simplify export dialog (@lfu, Tempfile creation (@gmcculloug)
- after review, simplify populate action (@lfu)
borisko123 added a commit to borisko123/manageiq that referenced this issue Jun 4, 2020
@borisko123
-Issue ManageIQ#20124
af0240a 
-fix error in spec example
-the test result depends on file order
-code style review
-modified according to miq-bot request
-fix rubocop offence
-add new flag (for dialog), modify specs
- after review, simplify export dialog (@lfu, Tempfile creation (@gmcculloug)
- refactor to inclide only dialog support stuff
borisko123 added a commit to borisko123/manageiq that referenced this issue Jun 4, 2020
@borisko123
-Issue ManageIQ#20124
2d8da36 
-fix error in spec example
-the test result depends on file order
-code style review
-modified according to miq-bot request
-fix rubocop offence
-add new flag (for dialog), modify specs
- after review, simplify export dialog (@lfu, Tempfile creation (@gmcculloug)
- refactor to include only dialog support stuff
- rubocop issues
borisko123 added a commit to borisko123/manageiq that referenced this issue Jun 6, 2020
@borisko123
-Issue ManageIQ#20124
257466c 
-fix error in spec example
-the test result depends on file order
-code style review
-modified according to miq-bot request
-fix rubocop offence
-add new flag (for dialog), modify specs
- after review, simplify export dialog (@lfu, Tempfile creation (@gmcculloug)
- refactor to include only dialog support stuff
- rubocop issues
borisko123 added a commit to borisko123/manageiq that referenced this issue Jun 11, 2020
@borisko123
-Issue ManageIQ#20124
da43b07 
-fix error in spec example
-the test result depends on file order
-code style review
-modified according to miq-bot request
-fix rubocop offence
-add new flag (for dialog), modify specs
- after review, simplify export dialog (@lfu, Tempfile creation (@gmcculloug)
- refactor to include only dialog support stuff
- rubocop issues
- review literal button name without let
@borisko123 borisko123 mentioned this issue Jun 13, 2020
Closed
borisko123 added a commit to borisko123/manageiq that referenced this issue Jun 17, 2020
@borisko123
-Issue ManageIQ#20124
a1fa28e 
-fix error in spec example
-the test result depends on file order
-code style review
-modified according to miq-bot request
-fix rubocop offence
-add new flag (for dialog), modify specs
- after review, simplify export dialog (@lfu, Tempfile creation (@gmcculloug)
- refactor to include only dialog support stuff
- rubocop issues
- review literal button name without let
- fix to be (be_an(CustomButton)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add dialog info when import/export custom buttons borisko123/manageiq
2 participants
@gtanzillo @borisko123