PG 9.6 - pg_stat_activity has no waiting column

[himdel]

Starting with postgres 9.6, there is no pg_stat_activity.waiting.

This causes two of our tests to fail:

  1) VmdbDatabaseConnection.log_statistics normal
     Failure/Error: expect(lines.shift).to eq "MIQ(VmdbDatabaseConnection.log_statistics) <<-ACTIVITY_STATS_CSV\n"
     
       expected: "MIQ(VmdbDatabaseConnection.log_statistics) <<-ACTIVITY_STATS_CSV\n"
            got: "MIQ(VmdbDatabaseConnection.log_statistics) Unable to log stats, 'undefined local variable or method `waiting' for #<VmdbDatabaseConnection:0x00561af9d10640>\n"
     
       (compared using ==)
     
       Diff:
       @@ -1,2 +1,2 @@
       -MIQ(VmdbDatabaseConnection.log_statistics) <<-ACTIVITY_STATS_CSV
       +MIQ(VmdbDatabaseConnection.log_statistics) Unable to log stats, 'undefined local variable or method `waiting' for #<VmdbDatabaseConnection:0x00561af9d10640>
       
     # ./spec/models/vmdb_database_connection_spec.rb:136:in `block (3 levels) in <top (required)>'

  2) VmdbDatabase.report_client_connections will return an array of hashes and verify hash keys for client connections query
     Failure/Error:
           data = select(<<-SQL, "Client Connections").to_a
                         SELECT client_addr   AS client_address
                              , datname       AS database
                              , pid           AS spid
                              , waiting       AS is_waiting
                              , query
                           FROM pg_stat_activity
                          ORDER BY 1, 2
                         SQL
     
     ActiveRecord::StatementInvalid:
       PG::UndefinedColumn: ERROR:  column "waiting" does not exist
       LINE 4:                        , waiting       AS is_waiting
                                        ^
       :                   SELECT client_addr   AS client_address
                              , datname       AS database
                              , pid           AS spid
                              , waiting       AS is_waiting
                              , query
                           FROM pg_stat_activity
                          ORDER BY 1, 2
     # ./lib/extensions/ar_adapter/ar_dba/postgresql.rb:15:in `client_connections'
     # ./app/models/vmdb_database.rb:77:in `report_client_connections'
     # ./spec/models/vmdb_database_spec.rb:77:in `block (3 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # PG::UndefinedColumn:
     #   ERROR:  column "waiting" does not exist
     #   LINE 4:                        , waiting       AS is_waiting
     #                                    ^
     #   ./lib/extensions/ar_adapter/ar_dba/postgresql.rb:15:in `client_connections'

rspec ./spec/models/vmdb_database_connection_spec.rb:133 # VmdbDatabaseConnection.log_statistics normal
rspec ./spec/models/vmdb_database_spec.rb:75 # VmdbDatabase.report_client_connections will return an array of hashes and verify hash keys for client connections query

My quick reading of 9.5 vs 9.6 would suggest the new way is to check wait_event IS NOT NULL, unless threre's some deeper semantic difference..

Cc @chrisarcand , @jrafanie

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[himdel]

@miq-bot remove_label stale

Still relevant :)