Skip to content

Commit

Permalink
Return custom buttons for service having nil service template
Browse files Browse the repository at this point in the history
  • Loading branch information
d-m-u committed Jul 16, 2018
1 parent d101c79 commit fd3520c
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 10 deletions.
10 changes: 8 additions & 2 deletions app/models/service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,17 @@ def power_states
end

def custom_actions
service_template&.custom_actions(self)
if service_template.nil?
buttons = CustomButton.where(:applies_to_class => "Service")
button_groups = CustomButtonSet.all.select { |f| f.set_data[:applies_to_class] == "Service" }
{:buttons => buttons, :button_groups => button_groups}
else
service_template.custom_actions(self)
end
end

def custom_action_buttons
service_template&.custom_action_buttons(self)
service_template ? service_template.custom_action_buttons(self) : CustomButton.where(:applies_to_class => "Service")
end

def power_state
Expand Down
35 changes: 27 additions & 8 deletions spec/models/service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -826,17 +826,36 @@ def create_deep_tree
let(:service_template) { FactoryGirl.create(:service_template) }
let(:service) { FactoryGirl.create(:service, :service_template => service_template) }

describe "#custom_actions" do
it "get list of custom actions from linked service template" do
expect(service_template).to receive(:custom_actions)
service.custom_actions
context "with template" do
describe "#custom_actions" do
it "get list of custom actions from linked service template" do
expect(service_template).to receive(:custom_actions)
service.custom_actions
end
end

describe "#custom_action_buttons" do
it "get list of custom action buttons from linked service template" do
expect(service_template).to receive(:custom_action_buttons)
service.custom_action_buttons
end
end
end

describe "#custom_action_buttons" do
it "get list of custom action buttons from linked service template" do
expect(service_template).to receive(:custom_action_buttons)
service.custom_action_buttons
context "without template" do
let!(:custom_button) { FactoryGirl.create(:custom_button, :applies_to_class => "Service") }
let(:service) { FactoryGirl.create(:service, :service_template_id => -1) }

describe "#custom_action_buttons" do
it "get list of custom action buttons on services" do
expect(service.custom_action_buttons).to include(custom_button)
end
end

describe "#custom_actions" do
it "get list of custom actions on services" do
expect(service.custom_actions).to include(:buttons => CustomButton.where(:applies_to_class => "Service"), :button_groups => [] )
end
end
end
end
Expand Down

0 comments on commit fd3520c

Please sign in to comment.