delete old default search from db if it is not supplied anymore

There is no easy way to correct typo in the name of search
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1740309

app/models/miq_search.rb

@@ -93,10 +93,10 @@ def self.seed
       name  = attrs['name']
       db    = attrs['db']
 
-      rec = searches["#{name}-#{db}"]
+      rec = searches.delete("#{name}-#{db}")
       if rec.nil?
         _log.info("Creating [#{name}]")
-        searches["#{name}-#{db}"] = create!(attrs)
+        create!(attrs)
       else
         # Avoid undoing user changes made to enable/disable default searches which is held in the search_key column
         attrs.delete('search_key')
@@ -109,6 +109,10 @@ def self.seed
         rec.save! if rec.changed?
       end
     end
+    if searches.any?
+      _log.warn("Deleting the following MiqSearch(es) as they no longer exist: #{searches.keys.sort.collect(&:inspect).join(", ")}")
+      MiqSearch.destroy(searches.values.map(&:id))
+    end
   end
 
   def self.display_name(number = 1)