Add check for invalid roles in server_role_names=

app/models/miq_server/role_management.rb

@@ -139,7 +139,12 @@ def server_role_names=(roles)
       if roles.blank?
         server_roles.delete_all
       else
-        desired = (roles == "*" ? ServerRole.all_names : roles.map { |role| role.strip.downcase }.sort)
+        all_roles = ServerRole.all_names
+
+        desired = (roles == "*" ? all_roles : roles.map { |role| role.strip.downcase }.sort)
+        invalid = desired - all_roles
+        raise ArgumentError, _("Roles <%{names}> not defined") % {:names => invalid.join(", ")} if invalid.any?
+
         current = server_role_names
 
         # MiqServer#server_role_names may include database scoped roles, which are managed elsewhere,

spec/models/miq_server/configuration_management_spec.rb

@@ -40,6 +40,8 @@
     let(:miq_server) { EvmSpecHelper.local_miq_server.tap(&:setup_drb_variables) }
 
     it "reloads the new changes into the settings for the resource" do
+      ServerRole.seed
+
       Vmdb::Settings.save!(miq_server, :some_test_setting => 2)
       expect(Settings.some_test_setting).to be_nil
       expect(miq_server).to receive(:notify_workers_of_config_change)

spec/models/miq_server/role_management_spec.rb

@@ -61,6 +61,10 @@
         @miq_server.role = desired
         expect(@miq_server.server_role_names).to eq(%w( ems_operations scheduler ))
       end
+
+      it "with an invalid role name" do
+        expect { @miq_server.role = 'foo' }.to raise_error(ArgumentError, /not defined/)
+      end
     end
 
     context "server_role_names=" do
@@ -88,6 +92,10 @@
         @miq_server.server_role_names = desired
         expect(@miq_server.server_role_names).to eq(%w[ems_operations scheduler])
       end
+
+      it "with an invalid role name" do
+        expect { @miq_server.server_role_names = ['foo'] }.to raise_error(ArgumentError, /not defined/)
+      end
     end
 
     it "should assign role properly when requested" do